From: "Jostein Kjønigsen" <jostein@secure.kjonigsen.net>
To: Eli Zaretskii <eliz@gnu.org>, jostein@kjonigsen.net
Cc: 59660@debbugs.gnu.org, casouri@gmail.com, theo@thornhill.no
Subject: bug#59660: lisp/progmodes/typescript-ts-mode.el: restore method-name fontification
Date: Mon, 28 Nov 2022 19:00:53 +0100 [thread overview]
Message-ID: <4e6b1aa3-dd41-5116-06f1-c69d4f1ce917@secure.kjonigsen.net> (raw)
In-Reply-To: <83y1rvm1ln.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1250 bytes --]
On 28.11.2022 18:27, Eli Zaretskii wrote:
>> Date: Mon, 28 Nov 2022 18:08:01 +0100
>> From: Jostein Kjønigsen<jostein@secure.kjonigsen.net>
>>
>> All fixes and one more squashed into the attached patch :)
> Which "all", please? AFAICT, you also posted a patch in another bug number,
> so is that also included?
No.
I've registered separate bugs for csharp-ts-mode and typescript-ts-mode,
since they are distinct major-modes with no code in common.
As such patches for C# has been sent to the C# bug.
And TypeScript patches have been sent to the TypeScript-bug.
As for "all", both csharp-ts-mode and typescript-ts-mode are "new"
modes, and as such probably will have a few ripening issues once tested
on real production code-bases and daily use (like I do now),
In name of brewity, I decided not to file a bug-report for every single
fontification issue I found, but rather bulk up the fixes per mode on
the respective bugs for those two languages. I hope this is OK.
As for TypeScript, IMO there still are a few minor issues wrt to how
font-lock-variable-name-face gets applied (or not), but I don't have
patches for those yet, and I would not consider them deal-breakers or
release-killers :)
--
Kind regards*
Jostein Kjønigsen*
[-- Attachment #2: Type: text/html, Size: 1940 bytes --]
next prev parent reply other threads:[~2022-11-28 18:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-28 15:04 bug#59660: 29.0.50; typescript-ts-mode consistently fontifies method-names incorrectly Jostein Kjønigsen
2022-11-28 15:09 ` bug#59660: lisp/progmodes/typescript-ts-mode.el: restore method-name fontification Jostein Kjønigsen
2022-11-28 16:44 ` Jostein Kjønigsen
2022-11-28 16:53 ` Jostein Kjønigsen
2022-11-28 17:08 ` Jostein Kjønigsen
2022-11-28 17:27 ` Eli Zaretskii
2022-11-28 18:00 ` Jostein Kjønigsen [this message]
2022-11-28 23:02 ` Yuan Fu
2022-11-28 23:06 ` bug#59660: 29.0.50; typescript-ts-mode consistently fontifies method-names incorrectly Yuan Fu
2022-11-29 12:10 ` Eli Zaretskii
2022-11-29 13:58 ` Jostein Kjønigsen
2022-11-29 14:30 ` Eli Zaretskii
2022-11-29 15:10 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-29 16:35 ` Jostein Kjønigsen
2022-11-29 16:39 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e6b1aa3-dd41-5116-06f1-c69d4f1ce917@secure.kjonigsen.net \
--to=jostein@secure.kjonigsen.net \
--cc=59660@debbugs.gnu.org \
--cc=casouri@gmail.com \
--cc=eliz@gnu.org \
--cc=jostein@kjonigsen.net \
--cc=theo@thornhill.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.