From: Jim Porter <jporterbugs@gmail.com>
To: Nicolas Martyanoff <nicolas@n16f.net>, emacs-devel@gnu.org
Subject: Re: [PATCH] em-cmpl: fix completion of command paths
Date: Tue, 7 Feb 2023 22:06:49 -0800 [thread overview]
Message-ID: <4261f6b0-5464-4a08-5006-34ab411a7a19@gmail.com> (raw)
In-Reply-To: <20230107121943.44658-1-nicolas@n16f.net>
Hi Nicolas,
On 1/7/2023 4:19 AM, Nicolas Martyanoff wrote:
> Completion was originally broken by 82c76e3.
>
> The use of `completion-table-dynamic' was introduced in 899055e to fix
> bug#48995. However the following issue remains: when completing a command
> path, absolute ("/usr/bin/") or relative ("./subdir/"), a space is
> automatically added at the end.
Thanks for this patch. I'm looking to add a regression test for this so
that it doesn't crop up again sometime in the future. However, I can't
seem to cause completion to fail as you describe, so it's hard to write
the test. I tried reverting your patch on the emacs-29 branch and then
running:
emacs -Q -f eshell
;; Within Eshell, enter:
/usr/bi<TAB>
This completes to "/usr/bin/|", where "|" is the point. However, that's
the correct behavior as far as I understand it, so I must be missing
something. Do you have more complete steps to reproduce this?
prev parent reply other threads:[~2023-02-08 6:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-07 12:19 [PATCH] em-cmpl: fix completion of command paths Nicolas Martyanoff
2023-01-07 12:23 ` Nicolas Martyanoff
2023-01-13 10:59 ` Nicolas Martyanoff
2023-01-25 17:03 ` Stefan Monnier
2023-01-25 17:15 ` Eli Zaretskii
2023-01-25 20:32 ` [PATCH] Update compat Nicolas Martyanoff
[not found] ` <87bkmmwcwx.fsf@valhala.localdomain>
2023-01-26 6:02 ` [PATCH] em-cmpl: fix completion of command paths Eli Zaretskii
2023-01-26 9:06 ` Eli Zaretskii
2023-01-26 12:21 ` Nicolas Martyanoff
2023-01-26 12:58 ` Eli Zaretskii
2023-01-28 0:11 ` Stefan Monnier
2023-01-28 8:27 ` Eli Zaretskii
2023-01-28 0:12 ` Stefan Monnier
2023-01-25 21:50 ` Jim Porter
2023-02-08 6:06 ` Jim Porter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4261f6b0-5464-4a08-5006-34ab411a7a19@gmail.com \
--to=jporterbugs@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=nicolas@n16f.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.