From: Jim Porter <jporterbugs@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>,
Nicolas Martyanoff <nicolas@n16f.net>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] em-cmpl: fix completion of command paths
Date: Wed, 25 Jan 2023 13:50:39 -0800 [thread overview]
Message-ID: <3dad6e29-3041-6164-b862-2e8a90020667@gmail.com> (raw)
In-Reply-To: <jwvtu0ek0ps.fsf-monnier+emacs-devel@gnu.org>
On 1/25/2023 9:03 AM, Stefan Monnier wrote:
>> The use of `completion-table-dynamic' was introduced in 899055e to fix
>> bug#48995. However the following issue remains: when completing a command
>> path, absolute ("/usr/bin/") or relative ("./subdir/"), a space is
>> automatically added at the end.
>> Bypassing `completion-table-dynamic' for filenames containing a directory
>> part fixes the final space bug and does not reintroduce bug#48995.
>
> This looks very good.
> IIUC this fixes a regression w.r.t Emacs-28, so it would be nice to
> install it into `emacs-29`.
I'm not sure about all the details of this bug, but over in bug#60845,
I'm adding some regression tests for completion in Eshell. It probably
wouldn't be too hard for someone (possibly me if I have time) to write
some regression tests for this command path issue too. Then hopefully
this won't cause problems in the future.
next prev parent reply other threads:[~2023-01-25 21:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-07 12:19 [PATCH] em-cmpl: fix completion of command paths Nicolas Martyanoff
2023-01-07 12:23 ` Nicolas Martyanoff
2023-01-13 10:59 ` Nicolas Martyanoff
2023-01-25 17:03 ` Stefan Monnier
2023-01-25 17:15 ` Eli Zaretskii
2023-01-25 20:32 ` [PATCH] Update compat Nicolas Martyanoff
[not found] ` <87bkmmwcwx.fsf@valhala.localdomain>
2023-01-26 6:02 ` [PATCH] em-cmpl: fix completion of command paths Eli Zaretskii
2023-01-26 9:06 ` Eli Zaretskii
2023-01-26 12:21 ` Nicolas Martyanoff
2023-01-26 12:58 ` Eli Zaretskii
2023-01-28 0:11 ` Stefan Monnier
2023-01-28 8:27 ` Eli Zaretskii
2023-01-28 0:12 ` Stefan Monnier
2023-01-25 21:50 ` Jim Porter [this message]
2023-02-08 6:06 ` Jim Porter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3dad6e29-3041-6164-b862-2e8a90020667@gmail.com \
--to=jporterbugs@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=nicolas@n16f.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.