all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dmitry@gutov.dev>
To: Juri Linkov <juri@linkov.net>, 65578@debbugs.gnu.org
Cc: "jo�o t�vora" <joaotavora@gmail.com>
Subject: bug#65578: Eglot with mouse
Date: Mon, 28 Aug 2023 16:41:12 +0300	[thread overview]
Message-ID: <402f3c93-748b-62d3-593f-4b852839deae@gutov.dev> (raw)
In-Reply-To: <86zg2beibp.fsf@mail.linkov.net>

On 28/08/2023 10:13, Juri Linkov wrote:
> xref-find-definitions-at-mouse uses save-excursion with
> mouse-set-point before calling xref-backend-identifier-at-point.
> But the same save-excursion with mouse-set-point can't be added
> around xref-find-definitions because save-excursion will restore
> the original position after visiting the found identifier.

Could we do that without additional save-excursion?

diff --git a/lisp/progmodes/xref.el b/lisp/progmodes/xref.el
index 0666b18cba1..0c3e34fe0a5 100644
--- a/lisp/progmodes/xref.el
+++ b/lisp/progmodes/xref.el
@@ -1637,7 +1637,9 @@ xref-find-definitions-at-mouse
             (mouse-set-point event)
             (xref-backend-identifier-at-point (xref-find-backend)))))
      (if identifier
-        (xref-find-definitions identifier)
+        (progn
+          (mouse-set-point event)
+          (xref-find-definitions identifier))
        (user-error "No identifier here"))))

  ;;;###autoload






  parent reply	other threads:[~2023-08-28 13:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-28  7:13 bug#65578: Eglot with mouse Juri Linkov
2023-08-28  9:20 ` João Távora
2023-08-28 13:41 ` Dmitry Gutov [this message]
2023-08-28 16:42   ` Juri Linkov
2023-08-28 17:00     ` Dmitry Gutov
2023-08-28 17:11       ` João Távora
2023-08-30 16:35       ` Juri Linkov
2023-08-31  0:27         ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=402f3c93-748b-62d3-593f-4b852839deae@gutov.dev \
    --to=dmitry@gutov.dev \
    --cc=65578@debbugs.gnu.org \
    --cc=joaotavora@gmail.com \
    --cc=juri@linkov.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.