From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#65578: Eglot with mouse Date: Mon, 28 Aug 2023 16:41:12 +0300 Message-ID: <402f3c93-748b-62d3-593f-4b852839deae@gutov.dev> References: <86zg2beibp.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6032"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Cc: =?UTF-8?Q?jo=EF=BF=BDo_?= =?UTF-8?Q?t=EF=BF=BDvora?= To: Juri Linkov , 65578@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Aug 28 15:42:16 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qacVU-0001O3-0e for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 28 Aug 2023 15:42:16 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qacVC-0002pw-0d; Mon, 28 Aug 2023 09:41:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qacVA-0002po-0G for bug-gnu-emacs@gnu.org; Mon, 28 Aug 2023 09:41:56 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qacV9-0001KL-Od for bug-gnu-emacs@gnu.org; Mon, 28 Aug 2023 09:41:55 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qacVG-0005co-3Q for bug-gnu-emacs@gnu.org; Mon, 28 Aug 2023 09:42:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 28 Aug 2023 13:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65578 X-GNU-PR-Package: emacs Original-Received: via spool by 65578-submit@debbugs.gnu.org id=B65578.169323009021581 (code B ref 65578); Mon, 28 Aug 2023 13:42:02 +0000 Original-Received: (at 65578) by debbugs.gnu.org; 28 Aug 2023 13:41:30 +0000 Original-Received: from localhost ([127.0.0.1]:47429 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qacUk-0005c0-Er for submit@debbugs.gnu.org; Mon, 28 Aug 2023 09:41:30 -0400 Original-Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:55605) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qacUi-0005bo-V4 for 65578@debbugs.gnu.org; Mon, 28 Aug 2023 09:41:29 -0400 Original-Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id E27893200754; Mon, 28 Aug 2023 09:41:15 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Mon, 28 Aug 2023 09:41:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1693230075; x=1693316475; bh=sk49lwGaXbJ6/fgNIzPytjYzg+uJ+S6Ocbl SS5MmQI4=; b=OcAw6O/oTn9Y6CmAEb1+LqqCk77Pag2TCUsAuh9ZOPSVs3aa+Gg iUAH8si/6sUxxtDly2RiIbUd1A5yQtj5Ot3eybiwKb2TNSxYHCiePnQ+2WrEKLqf x+lRyo6gbFwLPIx1Gt+VRYtdEw/0Ys/ZZOLRj6N4pekVxmXaFsJj7g8Jua1HALKW FjHPjgiBFqmbVP1oTnzYpv+JsNF/UW5gIyqaMToNgwvUfmmWRoJYcGY+w/FkDWti xtDUucvChlzNvWDhHVDd7xPBX9CVTTDeqPKo2MUv99ObN0xrQAtrS1k6Wkq4kvsG tKQLnkiIQzAAcDoZS4BaB5U8rYpBPCPifTg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1693230075; x=1693316475; bh=sk49lwGaXbJ6/fgNIzPytjYzg+uJ+S6Ocbl SS5MmQI4=; b=ixoCMicFaED5b6djX6LKyUwTD5IMfsNwlhLv6ORw38JM+TOeogV hmxredhF8mlsWFjK/qauu1X65rveCcifRhNc4h3kkIFcALAAECLinZva8V9YiUNL vKjaM28zZxcxDtnI/1TN7vw2OSOWfeyuO1f7A5hG6GsuXx4hw9o0tYIAlfPzyZYS 34XAzTEDrU54mVYGbI29/5L/NvELMlcZEjDXzmXioDogykyuK7H7zzCrcXF4RJ+C m1Kz6zOsAyaO28sX+R+qvBFedW28vPR2z1ZK/IYe7LUzUlkQqFKgjwAFMQeoJ6Pp T8g3v9jIlQsX+C07eZJLKBLbKKOMDmsI45w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrudefgedgieehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhepiefgteevheevveffheeltdeukeeiieekueefgedugfefgefhudelgfefveel vdevnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug hmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 28 Aug 2023 09:41:14 -0400 (EDT) Content-Language: en-US In-Reply-To: <86zg2beibp.fsf@mail.linkov.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:268628 Archived-At: On 28/08/2023 10:13, Juri Linkov wrote: > xref-find-definitions-at-mouse uses save-excursion with > mouse-set-point before calling xref-backend-identifier-at-point. > But the same save-excursion with mouse-set-point can't be added > around xref-find-definitions because save-excursion will restore > the original position after visiting the found identifier. Could we do that without additional save-excursion? diff --git a/lisp/progmodes/xref.el b/lisp/progmodes/xref.el index 0666b18cba1..0c3e34fe0a5 100644 --- a/lisp/progmodes/xref.el +++ b/lisp/progmodes/xref.el @@ -1637,7 +1637,9 @@ xref-find-definitions-at-mouse (mouse-set-point event) (xref-backend-identifier-at-point (xref-find-backend))))) (if identifier - (xref-find-definitions identifier) + (progn + (mouse-set-point event) + (xref-find-definitions identifier)) (user-error "No identifier here")))) ;;;###autoload