From: Dmitry Gutov <dgutov@yandex.ru>
To: emacs-devel@gnu.org, "Mattias Engdegård" <mattiase@acm.org>
Subject: Re: master 0724c6dbdae: Use string-search instead of string-match[-p] when possible
Date: Mon, 27 Mar 2023 02:05:26 +0300 [thread overview]
Message-ID: <286ac0ba-e6b4-c31b-a279-716a3b7d72c4@yandex.ru> (raw)
In-Reply-To: <20230326104755.356B1C1391D@vcs2.savannah.gnu.org>
Hi Mathias,
On 26/03/2023 13:47, Mattias Engdegård wrote:
> diff --git a/lisp/progmodes/ruby-ts-mode.el b/lisp/progmodes/ruby-ts-mode.el
> index d077c43ba52..d1034d467ab 100644
> --- a/lisp/progmodes/ruby-ts-mode.el
> +++ b/lisp/progmodes/ruby-ts-mode.el
> @@ -469,7 +469,7 @@ non-nil."
> (let* (first-call )
> (while (and parent
> (setq first-call (treesit-node-parent parent))
> - (string-match-p "call" (treesit-node-type first-call)))
> + (string-search "call" (treesit-node-type first-call)))
> (setq parent first-call))
> (treesit-node-start (treesit-search-subtree parent "\\." nil t))))
Thanks for this, it uncovered an existing bug in the code.
next parent reply other threads:[~2023-03-26 23:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <167982767456.13549.3313290435008922358@vcs2.savannah.gnu.org>
[not found] ` <20230326104755.356B1C1391D@vcs2.savannah.gnu.org>
2023-03-26 23:05 ` Dmitry Gutov [this message]
2023-03-26 23:35 ` master 0724c6dbdae: Use string-search instead of string-match[-p] when possible Emanuel Berg
2023-03-27 4:58 ` Yuan Fu
2023-03-27 12:47 ` Mattias Engdegård
2023-03-29 15:23 ` Robert Pluim
2023-03-29 15:34 ` Mattias Engdegård
2023-03-29 15:54 ` Robert Pluim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=286ac0ba-e6b4-c31b-a279-716a3b7d72c4@yandex.ru \
--to=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
--cc=mattiase@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.