From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: master 0724c6dbdae: Use string-search instead of string-match[-p] when possible Date: Mon, 27 Mar 2023 02:05:26 +0300 Message-ID: <286ac0ba-e6b4-c31b-a279-716a3b7d72c4@yandex.ru> References: <167982767456.13549.3313290435008922358@vcs2.savannah.gnu.org> <20230326104755.356B1C1391D@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37815"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 To: emacs-devel@gnu.org, =?UTF-8?Q?Mattias_Engdeg=c3=a5rd?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Mar 27 01:06:31 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pgZRX-0009fl-JB for ged-emacs-devel@m.gmane-mx.org; Mon, 27 Mar 2023 01:06:31 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pgZQd-0002fA-UV; Sun, 26 Mar 2023 19:05:35 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pgZQa-0002en-Fs for emacs-devel@gnu.org; Sun, 26 Mar 2023 19:05:33 -0400 Original-Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pgZQY-0003wH-BZ for emacs-devel@gnu.org; Sun, 26 Mar 2023 19:05:31 -0400 Original-Received: by mail-wm1-x32a.google.com with SMTP id l37so4043558wms.2 for ; Sun, 26 Mar 2023 16:05:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679871929; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=z3Xdsqm+myFrGdj8jiB6rqJACyIksUolz4TYhjvzVXw=; b=eA2N38VBluPZSRYsRCRJd1h/LpEW+I0c49HAU1H9faZ1FpikZSw83qLrNlprdIuoE6 04bnkrwSMHL2v9kziunWqKjl7zJd+qe0El6Q0MZZpf1L42Q4bariSj/JY8nQ/y9wscX0 pNjIQY8WFFrv4TgHQDFHUFxcft0+648jWRMyfbwZncmv8/sjfgE9qjX0GhN5Wt5G/P7z E3rlFBHogDerBG6RbP0YVTmDYQLb3kUqdDf/T94zjP0qw2Gwpkexcs+id1FHzEayUjak abhNPI/yELWPu2itEu822RIBf1UzW2x9pf0LmUmXHGi9wj0BVe49I0AUUfyX0ZHhp3Xx ez5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679871929; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=z3Xdsqm+myFrGdj8jiB6rqJACyIksUolz4TYhjvzVXw=; b=LvZ9dWXmOVdTNBymJn8I4ncOgvme+FvbSz5SGURaDp5xTXbjU00+qUHx3TI3W6oOGi GDVsBPUGXatsM6gjkbZAPGltvLE0JjT0w4NCsQ/Jnr/HhFnkA3ymsjH63fQ5s90hKfcD Si1X8mKUtGZbRW1ivligNXBzCKN6jeJGF1Lorble9e4Fa76rmbPzHugR+TaoFvXDpro0 9mAloGMQfjI8e5/0xzBcbyIjp5zIFylDmzV2UXCu7Aq3ignJJqaMD9uL2dWeSHFYGMAN /4OMyRQm1GhftCaxFgzbJFuHJbL/CoSgyXD5P5K1rVSOCI0gMXU89o+lqc9pJnJ1P2Bi 3EFg== X-Gm-Message-State: AO0yUKUKUjStcxiS5OCtpqVAS8DnW4ToOAUJD0hEKAj+pPyFgrEFFNuK dfJtb64boFVPSaVZmVv+bGagE0TxViFrNQ== X-Google-Smtp-Source: AK7set9mXuEuVpXR+xjP8+4VRVpOJ60Nx0+A6pFgMvKFQLN7p27naOzoSSfXw0sV8EfW2rffuaEqVA== X-Received: by 2002:a7b:c3d9:0:b0:3df:ef18:b0a1 with SMTP id t25-20020a7bc3d9000000b003dfef18b0a1mr8182318wmj.12.1679871928424; Sun, 26 Mar 2023 16:05:28 -0700 (PDT) Original-Received: from [192.168.0.2] ([85.132.229.92]) by smtp.googlemail.com with ESMTPSA id p5-20020a05600c358500b003ef6f87118dsm593006wmq.42.2023.03.26.16.05.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 26 Mar 2023 16:05:27 -0700 (PDT) Content-Language: en-US In-Reply-To: <20230326104755.356B1C1391D@vcs2.savannah.gnu.org> Received-SPF: pass client-ip=2a00:1450:4864:20::32a; envelope-from=raaahh@gmail.com; helo=mail-wm1-x32a.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:304779 Archived-At: Hi Mathias, On 26/03/2023 13:47, Mattias Engdegård wrote: > diff --git a/lisp/progmodes/ruby-ts-mode.el b/lisp/progmodes/ruby-ts-mode.el > index d077c43ba52..d1034d467ab 100644 > --- a/lisp/progmodes/ruby-ts-mode.el > +++ b/lisp/progmodes/ruby-ts-mode.el > @@ -469,7 +469,7 @@ non-nil." > (let* (first-call ) > (while (and parent > (setq first-call (treesit-node-parent parent)) > - (string-match-p "call" (treesit-node-type first-call))) > + (string-search "call" (treesit-node-type first-call))) > (setq parent first-call)) > (treesit-node-start (treesit-search-subtree parent "\\." nil t)))) Thanks for this, it uncovered an existing bug in the code.