bug#58319: 29.0.50; Not logical compilation warnings

["Mattias Engdegård" <mattias.engdegard@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 692 bytes --]

The warnings not being "logical" is of course nonsense, but I actually agree that '5+' is a tad on the obscure side. This is a human-facing message and we can be nicer: either '5 or more' or 'at least 5' would be clearer.

'5-10' is not quite as problematic. 'from 5 to 10' would probably do, and 'between 5 and 10' is better but also worse since it could be misinterpreted as the set {6..9} unless we append ' inclusive'. No strong opinion here.

As a special case, '5-6' is always better written as '5 or 6'.

I've looked through the various contexts where the messages appear and the patch below (which keeps 'X-Y') should be an improvement in all cases. Anyone strongly against?


[-- Attachment #2: arity-warning-message.diff --]
[-- Type: application/octet-stream, Size: 693 bytes --]

diff --git a/lisp/emacs-lisp/bytecomp.el b/lisp/emacs-lisp/bytecomp.el
index 03c45e44a5..74ba8984f2 100644
--- a/lisp/emacs-lisp/bytecomp.el
+++ b/lisp/emacs-lisp/bytecomp.el
@@ -1469,9 +1469,11 @@ byte-compile-arglist-signatures-congruent-p
 
 (defun byte-compile-arglist-signature-string (signature)
   (cond ((null (cdr signature))
-	 (format "%d+" (car signature)))
+	 (format "%d or more" (car signature)))
 	((= (car signature) (cdr signature))
 	 (format "%d" (car signature)))
+	((= (1+ (car signature)) (cdr signature))
+	 (format "%d or %d" (car signature) (cdr signature)))
 	(t (format "%d-%d" (car signature) (cdr signature)))))
 
 (defun byte-compile-function-warn (f nargs def)