From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#58319: 29.0.50; Not logical compilation warnings Date: Thu, 6 Oct 2022 12:54:29 +0200 Message-ID: <26A6DA68-340D-41CB-8CC8-992C86320399@gmail.com> References: <86o7uq5ds3.fsf@protected.rcdrun.com> Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) Content-Type: multipart/mixed; boundary="Apple-Mail=_0D2EB69E-F738-4A9E-B959-F33C388ECEAB" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25047"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , Stefan Monnier , Jean Louis To: 58319@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 06 12:55:41 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ogOXU-0006Ni-80 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 06 Oct 2022 12:55:40 +0200 Original-Received: from localhost ([::1]:58346 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ogOXT-0000zs-2M for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 06 Oct 2022 06:55:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40396) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ogOWt-0000wk-As for bug-gnu-emacs@gnu.org; Thu, 06 Oct 2022 06:55:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60003) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ogOWs-0001io-2r for bug-gnu-emacs@gnu.org; Thu, 06 Oct 2022 06:55:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ogOWr-0000NV-RQ for bug-gnu-emacs@gnu.org; Thu, 06 Oct 2022 06:55:01 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <86o7uq5ds3.fsf@protected.rcdrun.com> Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 06 Oct 2022 10:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58319 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: notabug Original-Received: via spool by 58319-submit@debbugs.gnu.org id=B58319.16650536791421 (code B ref 58319); Thu, 06 Oct 2022 10:55:01 +0000 Original-Received: (at 58319) by debbugs.gnu.org; 6 Oct 2022 10:54:39 +0000 Original-Received: from localhost ([127.0.0.1]:59081 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ogOWV-0000Mq-BR for submit@debbugs.gnu.org; Thu, 06 Oct 2022 06:54:39 -0400 Original-Received: from mail-lf1-f46.google.com ([209.85.167.46]:33331) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ogOWT-0000Md-G1 for 58319@debbugs.gnu.org; Thu, 06 Oct 2022 06:54:38 -0400 Original-Received: by mail-lf1-f46.google.com with SMTP id j4so2228493lfk.0 for <58319@debbugs.gnu.org>; Thu, 06 Oct 2022 03:54:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:cc:date:message-id:subject:mime-version:from:sender:from:to:cc :subject:date; bh=a9YWN5rjsyoLM6wPVQrwFoexATbK5yRvpvoohLSE2vo=; b=BGdGBlYmVV52iJ1yI620cDBiO0Svf8Jkw9WraR9LNuD2Lfav496Zke2TmI/CtUeuol w5oDC7DBEZ8oClOlER/pLkbYqutop8B1qBAbcsnQa+rSCU/BhDLPzyfm/NDDMuxgBWox VnA80ZeQ6jBcrVvi5Aj1H9mj4kiQOIHiOqMA29K6d+vFgNs7btNSsstAos4WrrU8mkN+ 4PDkhSPWMwV2xm1aohAYGOa9aTjufwEOjnzg+NgYO4mMo+j5d/rw+5i+xUh8fBofejvN ahAhuPw27L3lU8eHKPf7/1ouPozUBOXGM+Zug+MRADNmUMs9eoFdgwEjFNqFkOo6ggvL fA/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:cc:date:message-id:subject:mime-version:from:sender :x-gm-message-state:from:to:cc:subject:date; bh=a9YWN5rjsyoLM6wPVQrwFoexATbK5yRvpvoohLSE2vo=; b=FxLrZz0FsNVJmlBaVKpi/21mNjggtr3mR/kfoY+bOf2W8AVMyXiPd8QyUcNyq563iQ 2BCKj3ePxKUMAPn4o6oMnJFcuhWRx9f/HuP+dg5xDyQIeqZb4SApiGrrNXUA8piSoBvT Dq1Xl093np6i6VKhT5YUNsYErzbGqBbKBMXrfJRakz7rrz4XiRUK9PV6sUaXMjpiQxFA T3kH1B7AQpu1jwju7uWzf8j3ogQ5gv21PedAQySMFC9hai9UyChkCthdfZoSTMXyUrXW TR1k5Gc32hhYf3qZA7YAn7m6CdQlI0oJ+3f+Md4J47eK6rX49at2gSAIcSowRsqE2fPP Y+CQ== X-Gm-Message-State: ACrzQf05/yA2wHO1652PiJKMJ1Niw25OOeq114zk4zBSxAThoJ2oD0+H EJrXPJlOx52KLz+3dCz3QrPwbdUD6BoU7A== X-Google-Smtp-Source: AMsMyM7tj2R0GoVLe/5lKg81h8oWxb0f5En0feHPxYcIPGgrB7EycyCtwe0nzvQp6c3URe4rs0EZtg== X-Received: by 2002:a05:6512:308d:b0:4a2:33d3:b8f1 with SMTP id z13-20020a056512308d00b004a233d3b8f1mr1669381lfd.133.1665053671088; Thu, 06 Oct 2022 03:54:31 -0700 (PDT) Original-Received: from smtpclient.apple (c188-150-171-209.bredband.tele2.se. [188.150.171.209]) by smtp.gmail.com with ESMTPSA id 11-20020a05651c128b00b00268cfcf841asm1860849ljc.56.2022.10.06.03.54.30 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 06 Oct 2022 03:54:30 -0700 (PDT) X-Mailer: Apple Mail (2.3654.120.0.1.13) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:244636 Archived-At: --Apple-Mail=_0D2EB69E-F738-4A9E-B959-F33C388ECEAB Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii The warnings not being "logical" is of course nonsense, but I actually = agree that '5+' is a tad on the obscure side. This is a human-facing = message and we can be nicer: either '5 or more' or 'at least 5' would be = clearer. '5-10' is not quite as problematic. 'from 5 to 10' would probably do, = and 'between 5 and 10' is better but also worse since it could be = misinterpreted as the set {6..9} unless we append ' inclusive'. No = strong opinion here. As a special case, '5-6' is always better written as '5 or 6'. I've looked through the various contexts where the messages appear and = the patch below (which keeps 'X-Y') should be an improvement in all = cases. Anyone strongly against? --Apple-Mail=_0D2EB69E-F738-4A9E-B959-F33C388ECEAB Content-Disposition: attachment; filename=arity-warning-message.diff Content-Type: application/octet-stream; x-unix-mode=0644; name="arity-warning-message.diff" Content-Transfer-Encoding: 7bit diff --git a/lisp/emacs-lisp/bytecomp.el b/lisp/emacs-lisp/bytecomp.el index 03c45e44a5..74ba8984f2 100644 --- a/lisp/emacs-lisp/bytecomp.el +++ b/lisp/emacs-lisp/bytecomp.el @@ -1469,9 +1469,11 @@ byte-compile-arglist-signatures-congruent-p (defun byte-compile-arglist-signature-string (signature) (cond ((null (cdr signature)) - (format "%d+" (car signature))) + (format "%d or more" (car signature))) ((= (car signature) (cdr signature)) (format "%d" (car signature))) + ((= (1+ (car signature)) (cdr signature)) + (format "%d or %d" (car signature) (cdr signature))) (t (format "%d-%d" (car signature) (cdr signature))))) (defun byte-compile-function-warn (f nargs def) --Apple-Mail=_0D2EB69E-F738-4A9E-B959-F33C388ECEAB--