bug#60454: 30.0.50; `format-message' does not allow displaying "`" and "'" verbatim

bug#60454: 30.0.50; `format-message' does not allow displaying "`" and "'" verbatim

[Ihor Radchenko]

Hi,

Following up https://list.orgmode.org/87k027af5x.fsf@localhost/T/#t
and https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=62dc49509c8962bd2a19c4c4475fc616eebdfde8

`format-message' and thus also `warn' unconditionally replace _all_ the
instances of "`" and "'" in the message:

    This acts like ‘format’, except it also replaces each grave accent (`)
    by a left quote, and each apostrophe (') by a right quote.

However, sometimes, it is desired to keep these chars literal.
For example, `org-assert-version' displays a warning that suggests Elisp
code:

(warn "...
   It is recommended to put
    (straight-use-package 'org)
...")

Replacing "'" is undesired here and will make copy-pasted Elisp code
incorrect.

Would it be possible to introduce some kind of escape mechanism in
`format-message' to produce literal "'" and "`" when needed?

In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
 3.24.35, cairo version 1.17.6) of 2022-12-26 built on localhost
Repository revision: cc29fab3a66c59e77d0ff67c0f3e2e34ec80a03c
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101004
System Description: Gentoo Linux

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

bug#60454: 30.0.50; `format-message' does not allow displaying "`" and "'" verbatim

[Andreas Schwab]

On Dez 31 2022, Ihor Radchenko wrote:

> However, sometimes, it is desired to keep these chars literal.
> For example, `org-assert-version' displays a warning that suggests Elisp
> code:
>
> (warn "...
>    It is recommended to put
>     (straight-use-package 'org)
> ...")

The mangling only happens in the format string.  Pass the text as
argument and substitute it with %s.

(warn "...
   It is recommended to put
    %s
..." "(straight-use-package 'org)")

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."

bug#60454: 30.0.50; `format-message' does not allow displaying "`" and "'" verbatim

[Gregory Heytings]

>
> Would it be possible to introduce some kind of escape mechanism in 
> `format-message' to produce literal "'" and "`" when needed?
>

Just let-bind text-quoting-style:

(let ((text-quoting-style 'grave))
   (format-message "foo `bar' baz"))

bug#60454: 30.0.50; `format-message' does not allow displaying "`" and "'" verbatim

[Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors]

>> However, sometimes, it is desired to keep these chars literal.
>> For example, `org-assert-version' displays a warning that suggests Elisp
>> code:
>>
>> (warn "...
>>    It is recommended to put
>>     (straight-use-package 'org)
>> ...")
>
> The mangling only happens in the format string.  Pass the text as
> argument and substitute it with %s.
>
> (warn "...
>    It is recommended to put
>     %s
> ..." "(straight-use-package 'org)")

That's rather cumbersome.
I think it would make a lot of sense to offer escapes like %' and %`


        Stefan

bug#60454: 30.0.50; `format-message' does not allow displaying "`" and "'" verbatim

[Ihor Radchenko]

Gregory Heytings <gregory@heytings.org> writes:

>> Would it be possible to introduce some kind of escape mechanism in 
>> `format-message' to produce literal "'" and "`" when needed?
>>
>
> Just let-bind text-quoting-style:
>
> (let ((text-quoting-style 'grave))
>    (format-message "foo `bar' baz"))

This won't work when I sometimes actually want the replacement to
happen:

(format-message "This is variable `foo', and the code 'bar")

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

bug#60454: 30.0.50; `format-message' does not allow displaying "`" and "'" verbatim

[Gregory Heytings]

[-- Attachment #1: Type: text/plain, Size: 1149 bytes --]


>> Just let-bind text-quoting-style:
>>
>> (let ((text-quoting-style 'grave))
>>    (format-message "foo `bar' baz"))
>
> This won't work when I sometimes actually want the replacement to 
> happen:
>
> (format-message "This is variable `foo', and the code 'bar")
>

Indeed.  If you want both literal ` ' and interpreted ` ', until Stefan's 
suggestion is implemented, you can either use what Andreas suggested, or 
use a variant of format-message such as:

(defun format-message-alt (format &rest objects)
   "Format a string out of a format-string and arguments.

This acts like `format-message', which see, except that the grave
accent (\\=`) and apostrophe (\\=') can be escaped with `\\\\​=',
in which case they are not replaced by the left and right quote
replacement characters specified by `text-quoting-style'."
   (let* ((fq
 	  (replace-regexp-in-string
 	   "\\\\=`" "\uE001"
 	   (replace-regexp-in-string
 	    "\\\\='" "\uE000" format)))
 	 (fm (format-message fq objects))
 	 (fu
 	  (replace-regexp-in-string
 	   "\uE001" "`"
 	   (replace-regexp-in-string
 	    "\uE000" "'" fm))))
     fu))

bug#60454: 30.0.50; `format-message' does not allow displaying "`" and "'" verbatim

[Gregory Heytings]

And of course, if all you need is copy-pasteable code, you can use (quote 
...) instead of a literal quote: (use-package (quote foo)).