unofficial mirror of help-gnu-emacs@gnu.org
 help / color / mirror / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: Jean Louis <bugs@gnu.support>
Cc: "help-gnu-emacs@gnu.org" <help-gnu-emacs@gnu.org>
Subject: RE: [External] : Re: Testing whether a list contains at least one non-nil element
Date: Fri, 28 Oct 2022 05:07:01 +0000	[thread overview]
Message-ID: <SJ0PR10MB54884B658A0F2190468DF83DF3329@SJ0PR10MB5488.namprd10.prod.outlook.com> (raw)

> (defun check-if-any-elt-is-non-nil (list)
>   (let (there-is)
>     (while (and list (not there-is))
>       (when (car list) (setq there-is t))
>       (setq list (cdr list)))
>     there-is))

Sure, that works.  That's the same as one of
the functions I sent without bothering with
the `let' variable:

(defun foo (xs)
  (while (and (not (car xs)) xs)
    (setq xs (cdr xs)))
  (car xs))

> (benchmark 10000000 (check-if-any-elt-is-non-nil (append (list 1) (make-
> list 1000000 nil)))) ⇒ "Elapsed time: 0.771948s"
> 
> (benchmark 10000000 (check-if-any-elt-is-non-nil (append (make-list
> 1000000 nil) (list 1) ))) ⇒ "Elapsed time: 0.744323s"

I don't see that - at all. Did you really not
quote the second arg to `benchmark'?  Anyway,
take the list creations out of your timings.
___

You might compare the times needed to create
your two lists.  `append' is not symmetric.

Dunno just how `append' is implemented in C.
But you can see from a recursive Lisp
definition how different the two list args
are treated:

(defun apnd (xs ys)
  (if (null xs)
      ys
    (cons (car xs) (apnd (cdr xs) ys))))

It cdrs down the first list, recursing, but
just conses onto the second list.  So it
takes longer with a long first list and a
short second one than with the args reversed.
It traverses only the first of its list args.
Things like this are good to keep in mind.

Compare by hand (apnd nil '(1 2 3)) with
(apnd '(1 2 3) nil).  The first is done as
soon as it starts - no recursion at all. The
second recurses once for each element of the
first list: (cons 1 (cons 2 (cons 3 nil)))

(benchmark 1000 '(append (list 1) (make-list 10000 nil)))
"Elapsed time: 2.032493s (1.942879s in 45 GCs)"

(benchmark 1000 '(append (make-list 10000 nil) (list 1)))
"Elapsed time: 4.165245s (3.944074s in 91 GCs)"


             reply	other threads:[~2022-10-28  5:07 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-28  5:07 Drew Adams [this message]
  -- strict thread matches above, loose matches on Subject: below --
2022-10-25 10:16 Testing whether a list contains at least one non-nil element Heime
2022-10-25 10:50 ` Jean Louis
2022-10-25 12:12   ` Emanuel Berg
2022-10-26 18:56     ` Jean Louis
2022-10-27  3:54       ` [External] : " Drew Adams
2022-10-27  4:53         ` Jean Louis
2022-10-27  5:30           ` Emanuel Berg
2022-10-27 15:54           ` Drew Adams
2022-10-27 20:38             ` Jean Louis
2022-10-28  0:22               ` Emanuel Berg
2022-10-28  4:48               ` tomas
2022-10-28  5:19                 ` Jean Louis
2022-10-28  6:20                 ` Michael Heerdegen
2022-10-28 13:09                   ` Stefan Monnier via Users list for the GNU Emacs text editor
2022-10-29  6:10                     ` Michael Heerdegen
2022-10-29 15:25                       ` Stefan Monnier via Users list for the GNU Emacs text editor
2022-10-30 12:49                         ` Emanuel Berg
2022-10-29  6:38                     ` tomas
2022-10-30 12:48                     ` Emanuel Berg
2022-10-29  9:20                   ` Emanuel Berg
2022-10-29  9:19                 ` Emanuel Berg
2022-10-25 12:05 ` Michael Heerdegen
2022-10-25 15:59   ` [External] : " Drew Adams
2022-10-25 17:44     ` Emanuel Berg
2022-10-26 15:39       ` Drew Adams
2022-10-26 17:43         ` Emanuel Berg
2022-10-25 17:25 ` Joost Kremers
2022-10-25 19:44   ` Heime
2022-10-25 20:15     ` [External] : " Drew Adams
2022-10-25 20:19       ` Joost Kremers
2022-10-26  3:00         ` Stefan Monnier via Users list for the GNU Emacs text editor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SJ0PR10MB54884B658A0F2190468DF83DF3329@SJ0PR10MB5488.namprd10.prod.outlook.com \
    --to=drew.adams@oracle.com \
    --cc=bugs@gnu.support \
    --cc=help-gnu-emacs@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).