window-other.el / ref-lines.el

window-other.el / ref-lines.el

[Emanuel Berg]

(Pst, I don't know if "with other window" is a good idea,
 anyway it should then be called IN other window ... BTW, what
 does this (declare (indent 1) (debug t)) do?)

;;; -*- lexical-binding: t -*-
;;
;; this file:
;;   https://dataswamp.org/~incal/emacs-init/window-other.el

(defun next-window-buffer ()
  (window-buffer (next-window)) )

(defmacro with-other-window (&rest body)
  (declare (indent 1) (debug t))
  `(let ((buf (next-window-buffer)))
     (when (bufferp buf)
       (with-current-buffer buf
         ,@body) )))

(defun apply-in-other-window (fn &rest args)
  (let ((buf (next-window-buffer)))
    (when (bufferp buf)
      (with-current-buffer buf
        (apply fn args) ))))

(provide 'window-other)

;;; -*- lexical-binding: t -*-
;;
;; this file:
;;   https://dataswamp.org/~incal/emacs-init/ref-lines.el

(require 'window-other)

(defun ref-lines-ref ()
  (pcase-let ((`(,beg ,end) (if (use-region-p)
                                (list (line-number-at-pos (region-beginning))
                                      (line-number-at-pos (region-end)) )
                              (list (line-number-at-pos) nil) )))
    (if (and end (< beg end))
        (format "lines %d-%d" beg end)
      (format "line %d" beg) )))

(defun ref-lines (&optional other-win no-insert)
  (interactive "P")
  (let ((ref (if other-win
                 (apply-in-other-window #'ref-lines-ref)
               (ref-lines-ref) )))
    (when ref
      (if no-insert
          (prog1
              ref
            (message ref) )
        (insert ref) ))))

-- 
underground experts united
https://dataswamp.org/~incal

RE: [External] : window-other.el / ref-lines.el

[Drew Adams]

> (defun next-window-buffer ()
>   (window-buffer (next-window)) )
> 
> (defmacro with-other-window (&rest body)
>   (declare (indent 1) (debug t))
>   `(let ((buf (next-window-buffer)))
>      (when (bufferp buf)
>        (with-current-buffer buf
>          ,@body) )))

Your macro _name_ is misleading (and so would
be `in-other-window').  You're doing BODY with
the next-window's _buffer current_.  But you're
not _selecting_ the next-window while doing it.
IOW, that window isn't selected when you do BODY.

`with-selected-window' does its BODY with
its WINDOW selected.  You could (if that were
what you wanted) define a `with-other-window'
which did the equivalent for the `next-window':

(defmacro with-other-window (&rest body)
  `(with-selected-window (next-window) ,@body))

Re: [External] : window-other.el / ref-lines.el

[Emanuel Berg]

Drew Adams wrote:

> `with-selected-window' does its BODY with its WINDOW
> selected. You could (if that were what you wanted) define
> a `with-other-window' which did the equivalent for the
> `next-window':
>
> (defmacro with-other-window (&rest body)
>   `(with-selected-window (next-window) ,@body))

Okay, absolutely, didn't know of `with-selected-window' ...

-- 
underground experts united
https://dataswamp.org/~incal

FW: [External] : window-other.el / ref-lines.el

[Drew Adams]

[-- Attachment #1: Type: text/plain, Size: 1111 bytes --]

Forwarding to the list.  Apparently some msgs
I send to Emmanuel and the list don't end up
on the list.

-----Original Message-----
Sent: Tuesday, January 17, 2023 9:05 AM
To: Emanuel Berg <incal@dataswamp.org>; help-gnu-emacs@gnu.org
Subject: RE: [External] : window-other.el / ref-lines.el

> (defun next-window-buffer ()
>   (window-buffer (next-window)) )
> 
> (defmacro with-other-window (&rest body)
>   (declare (indent 1) (debug t))
>   `(let ((buf (next-window-buffer)))
>      (when (bufferp buf)
>        (with-current-buffer buf
>          ,@body) )))

Your macro _name_ is misleading (and so would
be `in-other-window').  You're doing BODY with
the next-window's _buffer current_.  But you're
not _selecting_ the next-window while doing it.
IOW, that window isn't selected when you do BODY.

`with-selected-window' does its BODY with
its WINDOW selected.  You could (if that were
what you wanted) define a `with-other-window'
which did the equivalent for the `next-window':

(defmacro with-other-window (&rest body)
  `(with-selected-window (next-window) ,@body))


[-- Attachment #2: winmail.dat --]
[-- Type: application/ms-tnef, Size: 13816 bytes --]