From: Eli Zaretskii <eliz@gnu.org>
To: help-gnu-emacs@gnu.org
Subject: Re: problems importing keys via epa-search-keys
Date: Sat, 11 Mar 2023 09:17:18 +0200 [thread overview]
Message-ID: <83mt4jycxt.fsf@gnu.org> (raw)
In-Reply-To: <m2edpwrz6k.fsf@fastmail.fm> (message from Filipp Gunbin on Sat, 11 Mar 2023 01:58:43 +0300)
> From: Filipp Gunbin <fgunbin@fastmail.fm>
> Cc: help-gnu-emacs@gnu.org, Philip Kaludercic <philipk@posteo.net>, Eli
> Zaretskii <eliz@gnu.org>
> Date: Sat, 11 Mar 2023 01:58:43 +0300
>
> Yes, broken since 23b6cd41f55b833e8a562c51642d36b5211a510b, the patch is
> below.
>
> Eli, would this be OK for emacs-29? This is clearly a regression.
It's a regression that existed since Emacs 28.1, right? So its fix
should try to avoid changing APIs. Therefore, please try to make a
change that leaves the signature of epa-ks--query-url unchanged, I
think it should be easy in this case. (Yes, I know it's an internal
function, but that doesn't mean we can change the signature when we
can avoid that.)
Thanks.
P.S. And why are you posting patches and their discussion here, not on
the bug tracker?
next prev parent reply other threads:[~2023-03-11 7:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-09 7:14 problems importing keys via epa-search-keys Giovanni Biscuolo
2023-03-10 22:58 ` Filipp Gunbin
2023-03-11 7:05 ` Giovanni Biscuolo
2023-03-11 22:10 ` Filipp Gunbin
2023-03-12 9:32 ` Giovanni Biscuolo
2023-03-11 7:17 ` Eli Zaretskii [this message]
2023-03-11 23:04 ` Filipp Gunbin
2023-03-12 6:33 ` Eli Zaretskii
2023-03-13 12:37 ` Filipp Gunbin
2023-03-13 14:43 ` Eli Zaretskii
2023-03-13 17:40 ` Filipp Gunbin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83mt4jycxt.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=help-gnu-emacs@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).