From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.help Subject: Re: problems importing keys via epa-search-keys Date: Sat, 11 Mar 2023 09:17:18 +0200 Message-ID: <83mt4jycxt.fsf@gnu.org> References: <87zg8mz998.fsf@xelera.eu> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10518"; mail-complaints-to="usenet@ciao.gmane.io" To: help-gnu-emacs@gnu.org Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Sat Mar 11 08:18:14 2023 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1patUb-0002VU-Gm for geh-help-gnu-emacs@m.gmane-mx.org; Sat, 11 Mar 2023 08:18:13 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1patU1-0002ns-54; Sat, 11 Mar 2023 02:17:37 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1patTz-0002nF-IL for help-gnu-emacs@gnu.org; Sat, 11 Mar 2023 02:17:35 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1patTz-0007hf-9K for help-gnu-emacs@gnu.org; Sat, 11 Mar 2023 02:17:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=lHdlumS3Wgi/InvHhSu6X9sGJHCnSq9bF9hNMlNY4iQ=; b=r34RlLmJNv/i A8ilWv07WWZrO75N3TCiioSgcWAjDOPhFAubow6ZR41JDeyLbgh74O1lOsFRb3kkBIYjzESHJ9eOx mRD4HwxKkY+IYIu5HHKzxnCWkBvmZGi2d1c9Yq71oVWZzqkuPX73UD0YY86zEQUkTRnp1NCaC31Jw 9BAlgU2WzRqKKhi4oLWVElcxNn+utBVrUmfouhXgsAisammC/sXO3cg2rU+gRMWaVEIW6Kj+fnA3r joVXwnlm1qvd7b39+7trCpzVInQCMdnOFfLJARMTPFRMYPoyKqhiAV3haJzpsZyJ5cU/iEtQ5dZPC e0YRKImI4salAG7GzXZg7w==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1patTy-0000O8-FP for help-gnu-emacs@gnu.org; Sat, 11 Mar 2023 02:17:34 -0500 In-Reply-To: (message from Filipp Gunbin on Sat, 11 Mar 2023 01:58:43 +0300) X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.help:142978 Archived-At: > From: Filipp Gunbin > Cc: help-gnu-emacs@gnu.org, Philip Kaludercic , Eli > Zaretskii > Date: Sat, 11 Mar 2023 01:58:43 +0300 > > Yes, broken since 23b6cd41f55b833e8a562c51642d36b5211a510b, the patch is > below. > > Eli, would this be OK for emacs-29? This is clearly a regression. It's a regression that existed since Emacs 28.1, right? So its fix should try to avoid changing APIs. Therefore, please try to make a change that leaves the signature of epa-ks--query-url unchanged, I think it should be easy in this case. (Yes, I know it's an internal function, but that doesn't mean we can change the signature when we can avoid that.) Thanks. P.S. And why are you posting patches and their discussion here, not on the bug tracker?