From: Rahguzar <rahguzar@zohomail.eu>
To: Peter Mao <peter.mao@gmail.com>
Cc: emacs-tangents@gnu.org, orzodk@fastmail.com,
Dmitry M <dmitrym@gmail.com>
Subject: Re: Continuous scroll for pdf-tools
Date: Wed, 05 Jul 2023 21:10:31 +0200 [thread overview]
Message-ID: <87o7kq2lti.fsf@zohomail.eu> (raw)
In-Reply-To: <CAEK3s1Ph9c5aaRonUhoF6MbV9Yx471f1yLJ3kjqvhHtbqQr4sg@mail.gmail.com>
Hi Peter,
Peter Mao <peter.mao@gmail.com> writes:
> Rahguzar -- are you going to be making pull-requests to the upstream
> repos? I notice that you are a fork of a fork of the "official"
> pdf-tools repo (vedang/pdf-tools), and your code has diverged
> significantly from vedang/pdf-tools (96 ahead/44 behind). Since
> vedang/pdf-tools is under active maintainership, I think the best
> course of action is to make a PR (or a series of PRs, as it looks like
> you've done a **lot** of work on this feature).
The reason that it is a fork of a fork is that once upon a time I
was using a feature from that fork which has a pull-request waiting to
be merged into vedang/pdf-tools. When I switched to Daniel Nicolai's
fork, I just rebased on top of that which looking back now is
unfortunate. You can probably tell I am not too familiar with git and
also not a software developer by trade. I have made changes to quite
a few places in the pdf-tools repo but what you see at first glance
vastly overstates them. By my estimation the changes for this feature
come to about 700 lines and probably a majority of them were by Daniel
Nicolai. In fact, although I fixed issues I had with pdf-tools when
using continuous scroll, I think I made more extensive changes to
image-roll than to pdf-tools.
For that reason I will like Daniel Nicolai to chime in about PR to
pdf-tools first and I opened an issue about changes to image-roll on his
repository. In any case the changes to pdf-tools are extensive but still
probably incomplete. Most likely there are features that break but I
haven't come across. As a result I think a pr to pdf-tools will take a
long time to review and merge. For a short term solution I think it
might be worthwhile to package the changes to pdf-tools as advices, this
will duplicate quite a lot of code but will allow people to test this
feature more easily with upstream pdf-tools. I don't have bandwidth to
take this on but if someone wants to try this, they are welcome.
Rahguzar
next prev parent reply other threads:[~2023-07-05 19:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-05 5:59 Continuous scroll for pdf-tools Peter Mao
2023-07-05 19:10 ` Rahguzar [this message]
2023-07-12 13:58 ` Rahguzar
2023-07-14 2:23 ` Peter Mao
-- strict thread matches above, loose matches on Subject: below --
2023-06-28 16:45 Rahguzar
2023-06-30 16:46 ` orzodk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o7kq2lti.fsf@zohomail.eu \
--to=rahguzar@zohomail.eu \
--cc=dmitrym@gmail.com \
--cc=emacs-tangents@gnu.org \
--cc=orzodk@fastmail.com \
--cc=peter.mao@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).