From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Rahguzar Newsgroups: gmane.emacs.tangents Subject: Re: Continuous scroll for pdf-tools Date: Wed, 05 Jul 2023 21:10:31 +0200 Message-ID: <87o7kq2lti.fsf@zohomail.eu> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26726"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.10.4; emacs 29.0.92 Cc: emacs-tangents@gnu.org, orzodk@fastmail.com, Dmitry M To: Peter Mao Original-X-From: emacs-tangents-bounces+get-emacs-tangents=m.gmane-mx.org@gnu.org Thu Jul 06 06:38:57 2023 Return-path: Envelope-to: get-emacs-tangents@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qHGld-0006oh-Kd for get-emacs-tangents@m.gmane-mx.org; Thu, 06 Jul 2023 06:38:57 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qHGlK-000261-FT; Thu, 06 Jul 2023 00:38:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qH8I1-0001Yk-68 for emacs-tangents@gnu.org; Wed, 05 Jul 2023 15:35:49 -0400 Original-Received: from sender11-pp-o91.zoho.eu ([31.186.226.249]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qH8Hz-0001BH-93 for emacs-tangents@gnu.org; Wed, 05 Jul 2023 15:35:48 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1688585740; cv=none; d=zohomail.eu; s=zohoarc; b=FSETsrC8vr+uAO56oXMGP9o+e6ZAcp+xC0BUS0uhEX7HLhbBk3eqy9yPSowln7ZyUYcTKVudLl1SzUWLWORzR4qP9Da14kZTZZKvFraH+jdFCRgZVLjtl2UPeMrVUJSUVhUfGfbpyzXg289npN5+dXWLATOY8ij24iz9yFECK5o= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.eu; s=zohoarc; t=1688585740; h=Content-Type:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=pNIccPf8EV7iNJSF7sRwj2DI1ILeXQFS9OA3ly08vAs=; b=B1ULRx8h42J/KB4lk99+gg0SJy6XUAUcHMMmDuNV5KaINPmI9FJThcBsURuctZ5QHK4KINl+TJ0IUh1VJckJU0xFFp+d7uGdTd/orWEiWtZtGwU4Lq+5kYA33Vx6QueeXO98Vt2yt5ilXlkk3qRcvEbUvtphtmi6ocQ3yX874jg= ARC-Authentication-Results: i=1; mx.zohomail.eu; dkim=pass header.i=zohomail.eu; spf=pass smtp.mailfrom=rahguzar@zohomail.eu; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1688585740; s=zoho; d=zohomail.eu; i=rahguzar@zohomail.eu; h=References:From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:In-reply-to:Message-ID:MIME-Version:Content-Type:Message-Id:Reply-To; bh=pNIccPf8EV7iNJSF7sRwj2DI1ILeXQFS9OA3ly08vAs=; b=BCfccqolX7X15gVJmFrD7h/I065cAAPWLq2Lre/o2XPIzzFsFubCGQv8NOi5FjmG bEXZfu8mfjfFaD+Eo2IuPbS4sXswC1jSIkhWw/37eaaukHAzdP2JWA35+rizRmgpZN+ cAMsDPK+0KzNkY+yUM7GJ1LA6TpFI88MgZg0tE/o= Original-Received: from localhost (85.191.222.215 [85.191.222.215]) by mx.zoho.eu with SMTPS id 1688585738448275.3405374019088; Wed, 5 Jul 2023 21:35:38 +0200 (CEST) In-reply-to: X-ZohoMailClient: External Received-SPF: pass client-ip=31.186.226.249; envelope-from=rahguzar@zohomail.eu; helo=sender11-pp-o91.zoho.eu X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Thu, 06 Jul 2023 00:38:37 -0400 X-BeenThere: emacs-tangents@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Emacs news and miscellaneous discussions outside the scope of other Emacs mailing lists List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-tangents-bounces+get-emacs-tangents=m.gmane-mx.org@gnu.org Original-Sender: emacs-tangents-bounces+get-emacs-tangents=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.tangents:1032 Archived-At: Hi Peter, Peter Mao writes: > Rahguzar -- are you going to be making pull-requests to the upstream > repos? I notice that you are a fork of a fork of the "official" > pdf-tools repo (vedang/pdf-tools), and your code has diverged > significantly from vedang/pdf-tools (96 ahead/44 behind). Since > vedang/pdf-tools is under active maintainership, I think the best > course of action is to make a PR (or a series of PRs, as it looks like > you've done a **lot** of work on this feature). The reason that it is a fork of a fork is that once upon a time I was using a feature from that fork which has a pull-request waiting to be merged into vedang/pdf-tools. When I switched to Daniel Nicolai's fork, I just rebased on top of that which looking back now is unfortunate. You can probably tell I am not too familiar with git and also not a software developer by trade. I have made changes to quite a few places in the pdf-tools repo but what you see at first glance vastly overstates them. By my estimation the changes for this feature come to about 700 lines and probably a majority of them were by Daniel Nicolai. In fact, although I fixed issues I had with pdf-tools when using continuous scroll, I think I made more extensive changes to image-roll than to pdf-tools. For that reason I will like Daniel Nicolai to chime in about PR to pdf-tools first and I opened an issue about changes to image-roll on his repository. In any case the changes to pdf-tools are extensive but still probably incomplete. Most likely there are features that break but I haven't come across. As a result I think a pr to pdf-tools will take a long time to review and merge. For a short term solution I think it might be worthwhile to package the changes to pdf-tools as advices, this will duplicate quite a lot of code but will allow people to test this feature more easily with upstream pdf-tools. I don't have bandwidth to take this on but if someone wants to try this, they are welcome. Rahguzar