From: Andrea Corallo <akrl@sdf.org>
To: Vibhav Pant <vibhavp@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] comp.c: Use the newly added bitcast API for type coercion, when available. (feature/jit-improved-type-punning)
Date: Tue, 04 Oct 2022 18:39:33 +0000 [thread overview]
Message-ID: <xjflepv8mca.fsf@ma.sdf.org> (raw)
In-Reply-To: <359f42c0c165c4b00c84a7818a89697e7cd28d50.camel@gmail.com> (Vibhav Pant's message of "Sun, 02 Oct 2022 22:57:40 +0530")
Vibhav Pant <vibhavp@gmail.com> writes:
> On Wed, 2022-09-28 at 12:37 +0000, Andrea Corallo wrote:
>> thanks for the patch, please find some comments below.
> Hi Andrea,
>
> Thanks for the feedback.
>
>>
>> Could you clarify why we need this double cast in both cases here?
>>
>
> gcc_jit_context_new_bitcast requires that the types being converted
> between have the same layout and as such, doesn't allow converting
> between an arbitrarily sized integer/boolean and a pointer. Casting it
> to a uintptr/void* is still necessary, to ensure that it can be bitcast
> into a void*/uintptr respectively.
I see thanks, I'd like to have a comment recording this in the code.
>> >
>>
>> Are this and the following new line added voluntarily?
>>
>
> Oops, fixed.
The patch is okay for me with the suggestions implemented. I assume you
have write access, if is not the case just post the patch here and I'll
install it.
Thanks for your work.
Bests
Andrea
next prev parent reply other threads:[~2022-10-04 18:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-27 18:15 [PATCH] comp.c: Use the newly added bitcast API for type coercion, when available. (feature/jit-improved-type-punning) Vibhav Pant
2022-09-27 18:18 ` Lars Ingebrigtsen
2022-09-28 12:39 ` Andrea Corallo
2022-09-28 12:37 ` Andrea Corallo
2022-10-02 17:27 ` Vibhav Pant
2022-10-04 18:39 ` Andrea Corallo [this message]
2022-10-05 9:21 ` Vibhav Pant
2022-10-05 10:42 ` Andrea Corallo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xjflepv8mca.fsf@ma.sdf.org \
--to=akrl@sdf.org \
--cc=emacs-devel@gnu.org \
--cc=vibhavp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).