Re: [PATCH] comp.c: Use the newly added bitcast API for type coercion, when available. (feature/jit-improved-type-punning)

[Vibhav Pant <vibhavp@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1196 bytes --]

On Tue, 2022-10-04 at 18:39 +0000, Andrea Corallo wrote:
> Vibhav Pant <vibhavp@gmail.com> writes:
> 
> > On Wed, 2022-09-28 at 12:37 +0000, Andrea Corallo wrote:
> > > thanks for the patch, please find some comments below.
> > Hi Andrea,
> > 
> > Thanks for the feedback.
> > 
> > > 
> > > Could you clarify why we need this double cast in both cases
> > > here?
> > > 
> > 
> > gcc_jit_context_new_bitcast requires that the types being converted
> > between have the same layout and as such, doesn't allow converting
> > between an arbitrarily sized integer/boolean and a pointer. Casting
> > it
> > to a uintptr/void* is still necessary, to ensure that it can be
> > bitcast
> > into a void*/uintptr respectively.
> 
> I see thanks, I'd like to have a comment recording this in the code.
> 
Good idea, done.

> > > 
> The patch is okay for me with the suggestions implemented.  I assume
> you
> have write access, if is not the case just post the patch here and
> I'll
> install it.
> 
Sure, I merged the branch last night. Thanks for the help.

Best,
Vibhav

-- 
Vibhav Pant
vibhavp@gmail.com
GPG: 7ED1 D48C 513C A024 BE3A  785F E3FB 28CB 6AB5 9598

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]