From: Andrea Corallo via "Emacs development discussions." <emacs-devel@gnu.org>
To: Andrea Corallo via "Emacs development discussions."
<emacs-devel@gnu.org>
Cc: Pip Cet <pipcet@gmail.com>
Subject: Re: feature/native-comp 5bc0855 2/2: Don't treat '=' as simple equality emitting constraints (bug#46812)
Date: Sat, 06 Mar 2021 22:18:13 +0000 [thread overview]
Message-ID: <xjfczwc2afu.fsf@sdf.org> (raw)
In-Reply-To: <xjf7dmn8i5g.fsf@sdf.org> (Andrea Corallo via's message of "Thu, 04 Mar 2021 07:58:19 +0000")
Andrea Corallo via "Emacs development discussions."
<emacs-devel@gnu.org> writes:
> Pip Cet <pipcet@gmail.com> writes:
>
>> On Tue, Mar 2, 2021 at 5:14 PM Pip Cet <pipcet@gmail.com> wrote:
>>> Don't forget this one either (currently miscompiled to have subr-type
>>> ((t) nil)):
>>>
>>> (lambda (x)
>>> (unless (= x 0.0) (error ""))
>>> (unless (eql x -0.0) (error ""))
>>> x)
>>
>> That one's still broken.
>>
>> (lambda (x) (if (eql x 1.0) (error "")) (unless (floatp x) (error "")) x)
>>
>> is also mis-analyzed to have subr-type (function (t) nil). However,
>> the compiled code appears to work correctly in both cases. Do you care
>> about such bugs?
>
> Indeed I care, but I'm not a full time Emacs developer, I just had no
> time to even look into this as ATM I'm busy on other fronts (including
> what pays my bills). Will come back on this as soon as I can.
The two reported miscompilations should be fixed now as of c60f2f458a,
please have a look.
Still have to look into the missed optimization for the null returning
function, will do.
Thanks
Andrea
next prev parent reply other threads:[~2021-03-06 22:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210228230215.15472.12941@vcs0.savannah.gnu.org>
[not found] ` <20210228230217.1971E20E1B@vcs0.savannah.gnu.org>
2021-03-02 5:20 ` feature/native-comp 5bc0855 2/2: Don't treat '=' as simple equality emitting constraints (bug#46812) Pip Cet
2021-03-02 13:47 ` Andrea Corallo via Emacs development discussions.
2021-03-02 14:16 ` Pip Cet
2021-03-02 14:30 ` Andrea Corallo via Emacs development discussions.
2021-03-02 17:14 ` Pip Cet
2021-03-04 7:36 ` Pip Cet
2021-03-04 7:58 ` Andrea Corallo via Emacs development discussions.
2021-03-06 22:18 ` Andrea Corallo via Emacs development discussions. [this message]
2021-03-07 7:03 ` Pip Cet
2021-03-07 7:07 ` Andrea Corallo via Emacs development discussions.
2021-03-07 7:13 ` Pip Cet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xjfczwc2afu.fsf@sdf.org \
--to=emacs-devel@gnu.org \
--cc=akrl@sdf.org \
--cc=pipcet@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).