From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo via "Emacs development discussions." Newsgroups: gmane.emacs.devel Subject: Re: feature/native-comp 5bc0855 2/2: Don't treat '=' as simple equality emitting constraints (bug#46812) Date: Sat, 06 Mar 2021 22:18:13 +0000 Message-ID: References: <20210228230215.15472.12941@vcs0.savannah.gnu.org> <20210228230217.1971E20E1B@vcs0.savannah.gnu.org> Reply-To: Andrea Corallo Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20103"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Pip Cet To: Andrea Corallo via "Emacs development discussions." Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Mar 06 23:18:48 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lIfG3-00056X-Oi for ged-emacs-devel@m.gmane-mx.org; Sat, 06 Mar 2021 23:18:47 +0100 Original-Received: from localhost ([::1]:52628 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lIfG2-0000aD-K6 for ged-emacs-devel@m.gmane-mx.org; Sat, 06 Mar 2021 17:18:46 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33448) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lIfFa-0000AS-3g for emacs-devel@gnu.org; Sat, 06 Mar 2021 17:18:18 -0500 Original-Received: from mx.sdf.org ([205.166.94.24]:64708) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lIfFY-0007vQ-27 for emacs-devel@gnu.org; Sat, 06 Mar 2021 17:18:17 -0500 Original-Received: from mab (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 126MID3Z023210 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Sat, 6 Mar 2021 22:18:13 GMT In-Reply-To: (Andrea Corallo via's message of "Thu, 04 Mar 2021 07:58:19 +0000") Received-SPF: pass client-ip=205.166.94.24; envelope-from=akrl@sdf.org; helo=mx.sdf.org X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:266105 Archived-At: Andrea Corallo via "Emacs development discussions." writes: > Pip Cet writes: > >> On Tue, Mar 2, 2021 at 5:14 PM Pip Cet wrote: >>> Don't forget this one either (currently miscompiled to have subr-type >>> ((t) nil)): >>> >>> (lambda (x) >>> (unless (= x 0.0) (error "")) >>> (unless (eql x -0.0) (error "")) >>> x) >> >> That one's still broken. >> >> (lambda (x) (if (eql x 1.0) (error "")) (unless (floatp x) (error "")) x) >> >> is also mis-analyzed to have subr-type (function (t) nil). However, >> the compiled code appears to work correctly in both cases. Do you care >> about such bugs? > > Indeed I care, but I'm not a full time Emacs developer, I just had no > time to even look into this as ATM I'm busy on other fronts (including > what pays my bills). Will come back on this as soon as I can. The two reported miscompilations should be fixed now as of c60f2f458a, please have a look. Still have to look into the missed optimization for the null returning function, will do. Thanks Andrea