Re: Toolkit scroll bar emulation in Carbon Emacs

[YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>]

>>>>> On Thu, 05 May 2005 15:56:58 +0900, YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp> said:

> For example, you'll see only a part of screen is updated when
> scrolling on slower machines if redisplay-dont-pause is nil.  This
> problem is related to the following issue, which was about mouse
> movement events, but scroll bar click events this time.

>   http://lists.gnu.org/archive/html/emacs-devel/2005-01/msg00240.html

How about the following patch?  It regards toolkit scroll bar thumb
drags as "squeezable" as well as mouse movements, and prevent
redisplay from being paused by these kinds of events.  Currently, only
thumb drags are delayed, but auto-repeats on other scroll bar parts do
pause redisplay as in the usual auto-repeats on keys.

				     YAMAMOTO Mitsuharu
				mituharu@math.s.chiba-u.ac.jp

Index: src/keyboard.c
===================================================================
RCS file: /cvsroot/emacs/emacs/src/keyboard.c,v
retrieving revision 1.822
diff -c -r1.822 keyboard.c
*** src/keyboard.c	2 May 2005 10:32:40 -0000	1.822
--- src/keyboard.c	7 May 2005 04:54:16 -0000
***************
*** 3531,3539 ****
       READABLE_EVENTS_FILTER_EVENTS is set, report it as empty.  */
    if (kbd_fetch_ptr != kbd_store_ptr)
      {
!       int have_live_event = 1;
! 
!       if (flags & READABLE_EVENTS_FILTER_EVENTS)
          {
            struct input_event *event;
  
--- 3531,3541 ----
       READABLE_EVENTS_FILTER_EVENTS is set, report it as empty.  */
    if (kbd_fetch_ptr != kbd_store_ptr)
      {
!       if (flags & (READABLE_EVENTS_FILTER_EVENTS
! #ifdef USE_TOOLKIT_SCROLL_BARS
! 		   | READABLE_EVENTS_IGNORE_SQUEEZABLES
! #endif
! 		   ))
          {
            struct input_event *event;
  
***************
*** 3541,3556 ****
                     ? kbd_fetch_ptr
                     : kbd_buffer);
  
!           while (have_live_event && event->kind == FOCUS_IN_EVENT)
!             {
!               event++;
                if (event == kbd_buffer + KBD_BUFFER_SIZE)
                  event = kbd_buffer;
!               if (event == kbd_store_ptr)
!                 have_live_event = 0;
!             }
          }
!       if (have_live_event) return 1;
      }
  
  #ifdef HAVE_MOUSE
--- 3543,3570 ----
                     ? kbd_fetch_ptr
                     : kbd_buffer);
  
! 	  do
! 	    {
! #ifdef USE_TOOLKIT_SCROLL_BARS
! 	      if (flags & READABLE_EVENTS_FILTER_EVENTS)
! #endif
! 		if (event->kind != FOCUS_IN_EVENT)
! 		  return 1;
! #ifdef USE_TOOLKIT_SCROLL_BARS
! 	      if (flags & READABLE_EVENTS_IGNORE_SQUEEZABLES)
! 		if (! (event->kind == SCROLL_BAR_CLICK_EVENT
! 		       && event->part == scroll_bar_handle
! 		       && event->modifiers == 0))
! 		  return 1;
! #endif
! 	      event++;
                if (event == kbd_buffer + KBD_BUFFER_SIZE)
                  event = kbd_buffer;
! 	    }
! 	  while (event != kbd_store_ptr);
          }
!       else
! 	return 1;
      }
  
  #ifdef HAVE_MOUSE
***************
*** 6545,6551 ****
     If READABLE_EVENTS_FILTER_EVENTS is set in FLAGS, ignore internal
     events (FOCUS_IN_EVENT).
     If READABLE_EVENTS_IGNORE_SQUEEZABLES is set in FLAGS, ignore mouse
!    movements. */
  
  static void
  get_input_pending (addr, flags)
--- 6559,6565 ----
     If READABLE_EVENTS_FILTER_EVENTS is set in FLAGS, ignore internal
     events (FOCUS_IN_EVENT).
     If READABLE_EVENTS_IGNORE_SQUEEZABLES is set in FLAGS, ignore mouse
!    movements and toolkit scroll bar thumb drags. */
  
  static void
  get_input_pending (addr, flags)