From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: YAMAMOTO Mitsuharu Newsgroups: gmane.emacs.devel Subject: Re: Toolkit scroll bar emulation in Carbon Emacs Date: Sat, 07 May 2005 14:18:41 +0900 Organization: Faculty of Science, Chiba University Message-ID: References: NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-Trace: sea.gmane.org 1115443283 21618 80.91.229.2 (7 May 2005 05:21:23 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 7 May 2005 05:21:23 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat May 07 07:21:19 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1DUHkW-00039q-7Q for ged-emacs-devel@m.gmane.org; Sat, 07 May 2005 07:21:12 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DUHsN-0005l1-0n for ged-emacs-devel@m.gmane.org; Sat, 07 May 2005 01:29:19 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DUHrG-0005QN-DI for emacs-devel@gnu.org; Sat, 07 May 2005 01:28:11 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DUHrA-0005Ne-Cf for emacs-devel@gnu.org; Sat, 07 May 2005 01:28:06 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DUHr7-0005Dt-JQ for emacs-devel@gnu.org; Sat, 07 May 2005 01:28:02 -0400 Original-Received: from [133.82.132.2] (helo=mathmail.math.s.chiba-u.ac.jp) by monty-python.gnu.org with esmtp (Exim 4.34) id 1DUHnc-0007Nb-46 for emacs-devel@gnu.org; Sat, 07 May 2005 01:24:24 -0400 Original-Received: from church.math.s.chiba-u.ac.jp (church [133.82.132.36]) by mathmail.math.s.chiba-u.ac.jp (Postfix) with ESMTP id EB8832CAF for ; Sat, 7 May 2005 14:18:41 +0900 (JST) Original-To: emacs-devel@gnu.org In-Reply-To: User-Agent: Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.6 (Marutamachi) APEL/10.6 Emacs/22.0.50 (sparc-sun-solaris2.8) MULE/5.0 (SAKAKI) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:36798 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:36798 >>>>> On Thu, 05 May 2005 15:56:58 +0900, YAMAMOTO Mitsuharu said: > For example, you'll see only a part of screen is updated when > scrolling on slower machines if redisplay-dont-pause is nil. This > problem is related to the following issue, which was about mouse > movement events, but scroll bar click events this time. > http://lists.gnu.org/archive/html/emacs-devel/2005-01/msg00240.html How about the following patch? It regards toolkit scroll bar thumb drags as "squeezable" as well as mouse movements, and prevent redisplay from being paused by these kinds of events. Currently, only thumb drags are delayed, but auto-repeats on other scroll bar parts do pause redisplay as in the usual auto-repeats on keys. YAMAMOTO Mitsuharu mituharu@math.s.chiba-u.ac.jp Index: src/keyboard.c =================================================================== RCS file: /cvsroot/emacs/emacs/src/keyboard.c,v retrieving revision 1.822 diff -c -r1.822 keyboard.c *** src/keyboard.c 2 May 2005 10:32:40 -0000 1.822 --- src/keyboard.c 7 May 2005 04:54:16 -0000 *************** *** 3531,3539 **** READABLE_EVENTS_FILTER_EVENTS is set, report it as empty. */ if (kbd_fetch_ptr != kbd_store_ptr) { ! int have_live_event = 1; ! ! if (flags & READABLE_EVENTS_FILTER_EVENTS) { struct input_event *event; --- 3531,3541 ---- READABLE_EVENTS_FILTER_EVENTS is set, report it as empty. */ if (kbd_fetch_ptr != kbd_store_ptr) { ! if (flags & (READABLE_EVENTS_FILTER_EVENTS ! #ifdef USE_TOOLKIT_SCROLL_BARS ! | READABLE_EVENTS_IGNORE_SQUEEZABLES ! #endif ! )) { struct input_event *event; *************** *** 3541,3556 **** ? kbd_fetch_ptr : kbd_buffer); ! while (have_live_event && event->kind == FOCUS_IN_EVENT) ! { ! event++; if (event == kbd_buffer + KBD_BUFFER_SIZE) event = kbd_buffer; ! if (event == kbd_store_ptr) ! have_live_event = 0; ! } } ! if (have_live_event) return 1; } #ifdef HAVE_MOUSE --- 3543,3570 ---- ? kbd_fetch_ptr : kbd_buffer); ! do ! { ! #ifdef USE_TOOLKIT_SCROLL_BARS ! if (flags & READABLE_EVENTS_FILTER_EVENTS) ! #endif ! if (event->kind != FOCUS_IN_EVENT) ! return 1; ! #ifdef USE_TOOLKIT_SCROLL_BARS ! if (flags & READABLE_EVENTS_IGNORE_SQUEEZABLES) ! if (! (event->kind == SCROLL_BAR_CLICK_EVENT ! && event->part == scroll_bar_handle ! && event->modifiers == 0)) ! return 1; ! #endif ! event++; if (event == kbd_buffer + KBD_BUFFER_SIZE) event = kbd_buffer; ! } ! while (event != kbd_store_ptr); } ! else ! return 1; } #ifdef HAVE_MOUSE *************** *** 6545,6551 **** If READABLE_EVENTS_FILTER_EVENTS is set in FLAGS, ignore internal events (FOCUS_IN_EVENT). If READABLE_EVENTS_IGNORE_SQUEEZABLES is set in FLAGS, ignore mouse ! movements. */ static void get_input_pending (addr, flags) --- 6559,6565 ---- If READABLE_EVENTS_FILTER_EVENTS is set in FLAGS, ignore internal events (FOCUS_IN_EVENT). If READABLE_EVENTS_IGNORE_SQUEEZABLES is set in FLAGS, ignore mouse ! movements and toolkit scroll bar thumb drags. */ static void get_input_pending (addr, flags)