unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Andy Moreton <andrewjmoreton@gmail.com>
To: emacs-devel@gnu.org
Subject: Re: master dfed333: Remove fixnum restriction on some display vars
Date: Thu, 23 May 2019 14:47:20 +0100	[thread overview]
Message-ID: <vz1r28p9tav.fsf@gmail.com> (raw)
In-Reply-To: 20190522202920.3CA7920498@vcs0.savannah.gnu.org

On Wed 22 May 2019, Paul Eggert wrote:

> diff --git a/src/lisp.h b/src/lisp.h
> index 876b757..6db9059 100644
> --- a/src/lisp.h
> +++ b/src/lisp.h
> @@ -2679,7 +2679,7 @@ struct Lisp_Buffer_Objfwd
>    {
>      enum Lisp_Fwd_Type type;	/* = Lisp_Fwd_Buffer_Obj */
>      int offset;
> -    /* One of Qnil, Qfixnump, Qsymbolp, Qstringp, Qfloatp or Qnumberp.  */
> +    /* One of Qnil, Qintegerp, Qsymbolp, Qstringp, Qfloatp or Qnumberp.  */
>      Lisp_Object predicate;
>    };

This fails to build if configured with "--enable-checking=structs" as
the hash has changed. This fixes it:

diff --git a/src/pdumper.c b/src/pdumper.c
index 28045d1959..5c14e950a0 100644
--- a/src/pdumper.c
+++ b/src/pdumper.c
@@ -2305,7 +2305,7 @@ static dump_off
 dump_fwd_buffer_obj (struct dump_context *ctx,
                      const struct Lisp_Buffer_Objfwd *buffer_objfwd)
 {
-#if CHECK_STRUCTS && !defined (HASH_Lisp_Buffer_Objfwd_13CA6B04FC)
+#if CHECK_STRUCTS && !defined (HASH_Lisp_Buffer_Objfwd_611EBD13FF)
 # error "Lisp_Buffer_Objfwd changed. See CHECK_STRUCTS comment."
 #endif
   struct Lisp_Buffer_Objfwd out;




  parent reply	other threads:[~2019-05-23 13:47 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20190522202917.27067.49863@vcs0.savannah.gnu.org>
     [not found] ` <20190522202920.3CA7920498@vcs0.savannah.gnu.org>
2019-05-22 21:06   ` [Emacs-diffs] master dfed333: Remove fixnum restriction on some display vars Stefan Monnier
2019-05-23 19:57     ` Paul Eggert
2019-05-24 14:32       ` Stefan Monnier
2019-05-24 20:13         ` Paul Eggert
2019-05-24 20:30           ` Eli Zaretskii
2019-05-24 21:31             ` Paul Eggert
2019-05-25 12:08           ` Stefan Monnier
2019-05-23 13:47   ` Andy Moreton [this message]
2019-05-23 20:02     ` Paul Eggert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=vz1r28p9tav.fsf@gmail.com \
    --to=andrewjmoreton@gmail.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).