From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Andy Moreton Newsgroups: gmane.emacs.devel Subject: Re: master dfed333: Remove fixnum restriction on some display vars Date: Thu, 23 May 2019 14:47:20 +0100 Message-ID: References: <20190522202917.27067.49863@vcs0.savannah.gnu.org> <20190522202920.3CA7920498@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="91013"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2.50 (windows-nt) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu May 23 15:47:43 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hTo4N-000NUn-Ol for ged-emacs-devel@m.gmane.org; Thu, 23 May 2019 15:47:43 +0200 Original-Received: from localhost ([127.0.0.1]:36689 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hTo4M-0004cq-OY for ged-emacs-devel@m.gmane.org; Thu, 23 May 2019 09:47:42 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:43062) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hTo4C-0004aS-Dt for emacs-devel@gnu.org; Thu, 23 May 2019 09:47:34 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hTo4B-0001Ub-J0 for emacs-devel@gnu.org; Thu, 23 May 2019 09:47:32 -0400 Original-Received: from [195.159.176.226] (port=41766 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hTo4B-0001Sv-CV for emacs-devel@gnu.org; Thu, 23 May 2019 09:47:31 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.89) (envelope-from ) id 1hTo47-000NDW-QO for emacs-devel@gnu.org; Thu, 23 May 2019 15:47:27 +0200 X-Injected-Via-Gmane: http://gmane.org/ Cancel-Lock: sha1:WLWB4JcW+BPlIaDFVeM52X1JI6o= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:236930 Archived-At: On Wed 22 May 2019, Paul Eggert wrote: > diff --git a/src/lisp.h b/src/lisp.h > index 876b757..6db9059 100644 > --- a/src/lisp.h > +++ b/src/lisp.h > @@ -2679,7 +2679,7 @@ struct Lisp_Buffer_Objfwd > { > enum Lisp_Fwd_Type type; /* = Lisp_Fwd_Buffer_Obj */ > int offset; > - /* One of Qnil, Qfixnump, Qsymbolp, Qstringp, Qfloatp or Qnumberp. */ > + /* One of Qnil, Qintegerp, Qsymbolp, Qstringp, Qfloatp or Qnumberp. */ > Lisp_Object predicate; > }; This fails to build if configured with "--enable-checking=structs" as the hash has changed. This fixes it: diff --git a/src/pdumper.c b/src/pdumper.c index 28045d1959..5c14e950a0 100644 --- a/src/pdumper.c +++ b/src/pdumper.c @@ -2305,7 +2305,7 @@ static dump_off dump_fwd_buffer_obj (struct dump_context *ctx, const struct Lisp_Buffer_Objfwd *buffer_objfwd) { -#if CHECK_STRUCTS && !defined (HASH_Lisp_Buffer_Objfwd_13CA6B04FC) +#if CHECK_STRUCTS && !defined (HASH_Lisp_Buffer_Objfwd_611EBD13FF) # error "Lisp_Buffer_Objfwd changed. See CHECK_STRUCTS comment." #endif struct Lisp_Buffer_Objfwd out;