unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Reiner Steib <reinersteib+gmane@imap.cc>
Cc: Chong Yidong <cyd@stupidchicken.com>,
	"Kim F. Storm" <storm@cua.dk>,
	emacs-devel@gnu.org
Subject: Re: tool bar icons not updated according to :active condition
Date: Sun, 05 Mar 2006 15:51:35 +0100	[thread overview]
Message-ID: <v91wxhdjwo.fsf@marauder.physik.uni-ulm.de> (raw)
In-Reply-To: <E1FFhZj-0005ZI-Te@fencepost.gnu.org> (Richard Stallman's message of "Sat, 04 Mar 2006 19:58:19 -0500")

On Sun, Mar 05 2006, Richard Stallman wrote:

>     I can't reproduce this problem anymore.  IOW: Updating the tool bar
>     using `force-window-update' via `run-with-idle-timer' works correctly.
>
> In that case, could you please delete the item from FOR-RELEASE?

I think there is a misunderstanding here: The initial problem (tool
bar icons not updated according to :active condition) still exists.

[ As already pointed out in a previous message, I agree with Chong
  Yidong that this problem should not block the release.  (This bug
  has already been there in Emacs 21.1 (and version 5.9 of Gnus
  bundled with it) and I don't recall any complaints about it.) ]

As a workaround for Emacs not updating the icon according to the :active
condition automatically, I added a `redraw-frame' call inside
`run-with-idle-timer'.  Kim suggested to use `force-window-update'
instead which didn't appear to work for me.  But `force-window-update'
does work as good as `redraw-frame' in the workaround.

What I have in the relevant mode (gnus-group-mode) now is:

      (add-to-list (make-local-variable 'post-command-hook)
		   'gnus-group-redraw-check)

(defvar gnus-group-redraw-when-idle 2
  "When non-nil, redraw the Group buffer frame when idle.
Internal variable.")

(defun gnus-group-redraw-check ()
  "Check if we need to redraw the frame."
  (when gnus-group-redraw-when-idle
    (run-with-idle-timer gnus-group-redraw-when-idle
			 nil 'force-window-update)))

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

  reply	other threads:[~2006-03-05 14:51 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-23 18:59 tool bar icons not updated according to :active condition Reiner Steib
2006-02-24 15:23 ` Chong Yidong
2006-02-25  9:31   ` Reiner Steib
2006-02-25 23:30     ` Kim F. Storm
2006-02-26 19:39       ` Reiner Steib
2006-02-27  9:04         ` Kim F. Storm
2006-03-02 19:20           ` Reiner Steib
2006-03-05  0:58             ` Richard Stallman
2006-03-05 14:51               ` Reiner Steib [this message]
2006-03-05 20:55                 ` Stefan Monnier
2006-03-05 21:57                   ` Reiner Steib
2006-02-26 12:15     ` Reiner Steib
2006-02-26 14:28       ` Chong Yidong
2006-02-27 19:02       ` Richard Stallman
2006-02-28 14:53         ` Reiner Steib
2006-03-04 22:25           ` Kim F. Storm
2006-03-08 14:36             ` Reiner Steib
2006-02-28 14:59         ` Chong Yidong
2006-02-28 15:06           ` Reiner Steib
2006-03-01 17:55           ` Richard Stallman
2006-03-04 15:14             ` Chong Yidong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=v91wxhdjwo.fsf@marauder.physik.uni-ulm.de \
    --to=reinersteib+gmane@imap.cc \
    --cc=Reiner.Steib@gmx.de \
    --cc=cyd@stupidchicken.com \
    --cc=emacs-devel@gnu.org \
    --cc=storm@cua.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).