From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Reiner Steib Newsgroups: gmane.emacs.devel Subject: Re: tool bar icons not updated according to :active condition Date: Sun, 05 Mar 2006 15:51:35 +0100 Message-ID: References: <873bi8ok5h.fsf@stupidchicken.com> Reply-To: Reiner Steib NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1141571049 7784 80.91.229.2 (5 Mar 2006 15:04:09 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 5 Mar 2006 15:04:09 +0000 (UTC) Cc: Chong Yidong , "Kim F. Storm" , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Mar 05 16:04:05 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1FFum3-0000Yf-K9 for ged-emacs-devel@m.gmane.org; Sun, 05 Mar 2006 16:03:56 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FFumA-0005mP-E8 for ged-emacs-devel@m.gmane.org; Sun, 05 Mar 2006 10:04:02 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1FFuls-0004cr-O8 for emacs-devel@gnu.org; Sun, 05 Mar 2006 10:03:45 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1FFulo-0004BQ-RR for emacs-devel@gnu.org; Sun, 05 Mar 2006 10:03:43 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FFulo-0004AM-Co for emacs-devel@gnu.org; Sun, 05 Mar 2006 10:03:40 -0500 Original-Received: from [134.60.1.1] (helo=mail.uni-ulm.de) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA:32) (Exim 4.52) id 1FFunj-0001Oq-OI; Sun, 05 Mar 2006 10:05:45 -0500 Original-Received: from bridgekeeper.physik.uni-ulm.de (bridgekeeper.physik.uni-ulm.de [134.60.10.123]) by mail.uni-ulm.de (8.13.4/8.13.4) with ESMTP id k25F319B017511; Sun, 5 Mar 2006 16:03:01 +0100 (MET) Original-Received: from viandante.physik.uni-ulm.de (bridgekeeper.physik.uni-ulm.de [134.60.10.123]) by bridgekeeper.physik.uni-ulm.de (Postfix) with SMTP id C907111057; Sun, 5 Mar 2006 16:02:56 +0100 (CET) Original-Received: (nullmailer pid 12470 invoked by uid 170); Sun, 05 Mar 2006 14:51:35 -0000 Original-To: Richard Stallman X-Face: /U7=m^"/-Dn61mAl{g9e3>\G5Tp,oEX|V)g2I1hBk\ML; )7A?6cmB-y7y?'NA^J<=oz7syB =(McAwIHgLX!.B?R3X}98d@?>CrT094KLWh]WU4gDpnL/")MS(XoQTv`Oq225uL>+; CpPXo$N5e>N> $tPd-gbB^F{gQS#1ase]XO~D4p4M"3+F-7~u]dy3I?Pb8RO*H-EFeWDUf?Rf, d]pv\Jvh2Cht!A=im yKAS2Z%Ao^;}W/qzMvMm In-Reply-To: (Richard Stallman's message of "Sat, 04 Mar 2006 19:58:19 -0500") User-Agent: Gnus/5.110004 (No Gnus v0.4) Emacs/22.0.50 (gnu/linux) X-DCC-Servercave-Metrics: gemini 1183; Body=4 Fuz1=4 Fuz2=4 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:51230 Archived-At: On Sun, Mar 05 2006, Richard Stallman wrote: > I can't reproduce this problem anymore. IOW: Updating the tool bar > using `force-window-update' via `run-with-idle-timer' works correctly. > > In that case, could you please delete the item from FOR-RELEASE? I think there is a misunderstanding here: The initial problem (tool bar icons not updated according to :active condition) still exists. [ As already pointed out in a previous message, I agree with Chong Yidong that this problem should not block the release. (This bug has already been there in Emacs 21.1 (and version 5.9 of Gnus bundled with it) and I don't recall any complaints about it.) ] As a workaround for Emacs not updating the icon according to the :active condition automatically, I added a `redraw-frame' call inside `run-with-idle-timer'. Kim suggested to use `force-window-update' instead which didn't appear to work for me. But `force-window-update' does work as good as `redraw-frame' in the workaround. What I have in the relevant mode (gnus-group-mode) now is: (add-to-list (make-local-variable 'post-command-hook) 'gnus-group-redraw-check) (defvar gnus-group-redraw-when-idle 2 "When non-nil, redraw the Group buffer frame when idle. Internal variable.") (defun gnus-group-redraw-check () "Check if we need to redraw the frame." (when gnus-group-redraw-when-idle (run-with-idle-timer gnus-group-redraw-when-idle nil 'force-window-update))) Bye, Reiner. -- ,,, (o o) ---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/