unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Jason Rumney <jasonr@gnu.org>
Cc: emacs-devel@gnu.org, Kenichi Handa <handa@m17n.org>
Subject: Re: char-displayable-p issue
Date: 22 Oct 2003 20:53:55 +0100	[thread overview]
Message-ID: <ubrs9f3qk.fsf@jasonrumney.net> (raw)
In-Reply-To: <20031022190950.32420.qmail@web60304.mail.yahoo.com>

Michael Mauger <mmaug@yahoo.com> writes:

> 3. Modify `x_to_w32_font' to handle the forms:
>    -FOUNDRY-*-REGISTRY-ENCODING
>    -*-REGISTRY-ENCODING
> 
>    The code in this routine is a little fragile.  There are many
>    special cases handled implicitly without explicit acknowledgement
>    that they are there.  

> I see option 3 as the ideal, and I will start to work on it. 

Thank you. I have tweaked that bit of code many times now to fix
bugs like this, it could do with a fresh set of eyes. Please document
any implicit special cases that you find.

> One other issue: Kenichi Handa said that the car of font-pattern
> could be one of "FOUNDRY-FAMILY", "*FAMILY", or "FOUNDRY*", in
> addition to nil.  My solution would not handle the "*FAMILY" form
> unless it is really sent as "*-FAMILY".  The Windows code does
> not handle partial wildcards in the font pattern.

I recently changed the font selection code in the emacs-unicode-2
branch to fix the same problem in charset and encoding fields. The
approach I took is to treat partial wildcards as full wildcards in
x_to_w32_charset, and to do more thorough comparisons in
enum_font_cb2.

> Trying to accommodate the partial wildcards in `x_to_w32_font' may
> break other usages.

That is my experience with trying to do anything in x_to_w32_font. It
is not an easy piece of code to get "right". That is why I have not
rushed into merging the changes I made to get emacs-unicode-2 to work
back into HEAD.

  reply	other threads:[~2003-10-22 19:53 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-10-22 19:09 char-displayable-p issue Michael Mauger
2003-10-22 19:53 ` Jason Rumney [this message]
2003-10-23 20:21   ` Michael Mauger
  -- strict thread matches above, loose matches on Subject: below --
2003-10-27 23:48 Michael Mauger
2003-10-28  8:21 ` Jason Rumney
2003-10-28 15:12   ` Michael Mauger
2003-10-21 23:22 Michael Mauger
2003-10-22  5:51 ` Kenichi Handa
2003-10-22 16:00   ` Michael Mauger
2003-10-08  7:04 David PONCE
2003-10-13 23:40 ` Kenichi Handa
2003-10-14  5:56   ` David Ponce

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ubrs9f3qk.fsf@jasonrumney.net \
    --to=jasonr@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=handa@m17n.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).