From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Jason Rumney Newsgroups: gmane.emacs.devel Subject: Re: char-displayable-p issue Date: 22 Oct 2003 20:53:55 +0100 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: References: <20031022190950.32420.qmail@web60304.mail.yahoo.com> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1066852570 16632 80.91.224.253 (22 Oct 2003 19:56:10 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 22 Oct 2003 19:56:10 +0000 (UTC) Cc: emacs-devel@gnu.org, Kenichi Handa Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Wed Oct 22 21:56:08 2003 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1ACP5U-0003K3-00 for ; Wed, 22 Oct 2003 21:56:08 +0200 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1ACP5T-0008IU-00 for ; Wed, 22 Oct 2003 21:56:07 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.24) id 1ACP4g-0006ox-T4 for emacs-devel@quimby.gnus.org; Wed, 22 Oct 2003 15:55:18 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24) id 1ACP4E-0006oW-Cr for emacs-devel@gnu.org; Wed, 22 Oct 2003 15:54:50 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24) id 1ACP3i-0006NL-A1 for emacs-devel@gnu.org; Wed, 22 Oct 2003 15:54:49 -0400 Original-Received: from [194.106.33.36] (helo=server0027.freedom2surf.net) by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168) (Exim 4.24) id 1ACP3h-0006Lz-S2 for emacs-devel@gnu.org; Wed, 22 Oct 2003 15:54:17 -0400 Original-Received: from wanchan.jasonr.f2s.com ([195.137.103.251]) by server0027.freedom2surf.net (8.12.6/8.12.6/Debian-7) with ESMTP id h9MJsFR7002842; Wed, 22 Oct 2003 19:54:15 GMT Original-Received: from NYAUMO (nyaumo.jasonrumney.net [10.0.0.27]) by wanchan.jasonr.f2s.com (Postfix) with ESMTP id D534EDDD70; Wed, 22 Oct 2003 20:52:47 +0100 (BST) Original-To: Michael Mauger In-Reply-To: <20031022190950.32420.qmail@web60304.mail.yahoo.com> Original-Lines: 35 User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.2 Precedence: list List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:17354 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:17354 Michael Mauger writes: > 3. Modify `x_to_w32_font' to handle the forms: > -FOUNDRY-*-REGISTRY-ENCODING > -*-REGISTRY-ENCODING > > The code in this routine is a little fragile. There are many > special cases handled implicitly without explicit acknowledgement > that they are there. > I see option 3 as the ideal, and I will start to work on it. Thank you. I have tweaked that bit of code many times now to fix bugs like this, it could do with a fresh set of eyes. Please document any implicit special cases that you find. > One other issue: Kenichi Handa said that the car of font-pattern > could be one of "FOUNDRY-FAMILY", "*FAMILY", or "FOUNDRY*", in > addition to nil. My solution would not handle the "*FAMILY" form > unless it is really sent as "*-FAMILY". The Windows code does > not handle partial wildcards in the font pattern. I recently changed the font selection code in the emacs-unicode-2 branch to fix the same problem in charset and encoding fields. The approach I took is to treat partial wildcards as full wildcards in x_to_w32_charset, and to do more thorough comparisons in enum_font_cb2. > Trying to accommodate the partial wildcards in `x_to_w32_font' may > break other usages. That is my experience with trying to do anything in x_to_w32_font. It is not an easy piece of code to get "right". That is why I have not rushed into merging the changes I made to get emacs-unicode-2 to work back into HEAD.