From: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org, jasonr@gnu.org
Subject: Re: "checksum failure after patch" in CVS
Date: Tue, 05 Jul 2005 06:30:25 +0200 [thread overview]
Message-ID: <uacl1q3ha.fsf@gnu.org> (raw)
In-Reply-To: <f7ccd24b050704160865a19771@mail.gmail.com> (message from Juanma Barranquero on Tue, 5 Jul 2005 01:08:01 +0200)
> Date: Tue, 5 Jul 2005 01:08:01 +0200
> From: Juanma Barranquero <lekktu@gmail.com>
> Cc: Emacs Devel <emacs-devel@gnu.org>
>
> On 7/4/05, Jason Rumney <jasonr@gnu.org> wrote:
>
> > It's not in binary format in the repository, we deliberately avoid
> > binary format for text files, even when we need to check them in with
> > DOS line ends, because we know that binary format is inconvenient.
>
> It's a terminology issue. You're right the file is in "text" mode in
> the repository, but when a file is in the repository in text mode with
> CR/LF pairs, in my view it is a binary file masquerading as a text
> one.
It is no more binary than a Unix-style file such as configure.in.
You are, in effect, saying that Emacs is wrong decoding non-Unix EOLs
and treating the result as text by hiding the alien EOL sequences from
the user when it displays the file. Because if config.bat is a binary
file, we should have visited it with no-conversion.
> I will not say the CVSNT client is right in doing CR/LF ->
> CR/CR/LF, because it obviously is gaffing. But having a CR/LF file in
> the repo as text file is evil, was evil, will forever be evil.
It's not evil because storing it as a binary loses some valuable
features of CVS, like the ability to say "cvs diff", "cvs annotate",
etc.
What _is_ evil is the broken manner in which Windows CVS clients
handle the EOL issue.
> It seems config.bat had LF on the repo and some recent change has
> updated it with CR/LF.
No, config.bat was always stored with DOS EOLs in the Emacs CVS.
next prev parent reply other threads:[~2005-07-05 4:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-04 14:41 "checksum failure after patch" in CVS Juanma Barranquero
2005-07-04 14:47 ` Juanma Barranquero
2005-07-04 15:45 ` Jason Rumney
2005-07-04 22:50 ` Eli Zaretskii
2005-07-04 22:34 ` Jason Rumney
2005-07-04 23:08 ` Juanma Barranquero
2005-07-05 4:30 ` Eli Zaretskii [this message]
2005-07-05 8:23 ` Juanma Barranquero
2005-07-05 21:18 ` Eli Zaretskii
2005-07-04 22:47 ` Eli Zaretskii
2005-07-04 22:59 ` Juanma Barranquero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=uacl1q3ha.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=jasonr@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).