From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: "checksum failure after patch" in CVS Date: Tue, 05 Jul 2005 06:30:25 +0200 Message-ID: References: <42C959B4.6070308@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: main.gmane.org X-Trace: sea.gmane.org 1120534447 21525 80.91.229.2 (5 Jul 2005 03:34:07 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 5 Jul 2005 03:34:07 +0000 (UTC) Cc: emacs-devel@gnu.org, jasonr@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jul 05 05:33:58 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1DpeBo-0005i0-W4 for ged-emacs-devel@m.gmane.org; Tue, 05 Jul 2005 05:33:41 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DpeD1-0005mp-9I for ged-emacs-devel@m.gmane.org; Mon, 04 Jul 2005 23:34:55 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DpeAc-0004Po-10 for emacs-devel@gnu.org; Mon, 04 Jul 2005 23:32:26 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DpeAY-0004Nx-Dw for emacs-devel@gnu.org; Mon, 04 Jul 2005 23:32:22 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DpeAX-0004N1-VN for emacs-devel@gnu.org; Mon, 04 Jul 2005 23:32:22 -0400 Original-Received: from [192.114.186.24] (helo=legolas.inter.net.il) by monty-python.gnu.org with esmtp (Exim 4.34) id 1DpeEf-0005rs-FP; Mon, 04 Jul 2005 23:36:37 -0400 Original-Received: from HOME-C4E4A596F7 (IGLD-83-130-203-139.inter.net.il [83.130.203.139]) by legolas.inter.net.il (MOS 3.5.8-GR) with ESMTP id EUX14103 (AUTH halo1); Tue, 5 Jul 2005 06:30:27 +0300 (IDT) Original-To: Juanma Barranquero In-reply-to: (message from Juanma Barranquero on Tue, 5 Jul 2005 01:08:01 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:40383 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:40383 > Date: Tue, 5 Jul 2005 01:08:01 +0200 > From: Juanma Barranquero > Cc: Emacs Devel > > On 7/4/05, Jason Rumney wrote: > > > It's not in binary format in the repository, we deliberately avoid > > binary format for text files, even when we need to check them in with > > DOS line ends, because we know that binary format is inconvenient. > > It's a terminology issue. You're right the file is in "text" mode in > the repository, but when a file is in the repository in text mode with > CR/LF pairs, in my view it is a binary file masquerading as a text > one. It is no more binary than a Unix-style file such as configure.in. You are, in effect, saying that Emacs is wrong decoding non-Unix EOLs and treating the result as text by hiding the alien EOL sequences from the user when it displays the file. Because if config.bat is a binary file, we should have visited it with no-conversion. > I will not say the CVSNT client is right in doing CR/LF -> > CR/CR/LF, because it obviously is gaffing. But having a CR/LF file in > the repo as text file is evil, was evil, will forever be evil. It's not evil because storing it as a binary loses some valuable features of CVS, like the ability to say "cvs diff", "cvs annotate", etc. What _is_ evil is the broken manner in which Windows CVS clients handle the EOL issue. > It seems config.bat had LF on the repo and some recent change has > updated it with CR/LF. No, config.bat was always stored with DOS EOLs in the Emacs CVS.