unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Procedure for reverting commits on release branch
@ 2020-05-03 17:20 Glenn Morris
  2020-05-03 17:36 ` Eli Zaretskii
  2021-01-04 17:06 ` Glenn Morris
  0 siblings, 2 replies; 3+ messages in thread
From: Glenn Morris @ 2020-05-03 17:20 UTC (permalink / raw)
  To: emacs-devel


If a commit is made on the release branch, and then one wants to instead
have it only on master, then given the following commit sequence:

1) emacs-27: do something
2) emacs-27: revert something
3) master: do something

If gitmerge.el is now used to merge emacs-27 to master:
commit 1) is skipped, because it is already on master
commit 2) is merged

Net result: 3) is reverted on master and has to be applied again by hand.

Specific recent example: lisp/calculator.el


A more efficient way to do this would be:
1) emacs-27: do something
2) emacs-27: revert something, and mark "do not merge to master"

Then no special handling is needed. 



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Procedure for reverting commits on release branch
  2020-05-03 17:20 Procedure for reverting commits on release branch Glenn Morris
@ 2020-05-03 17:36 ` Eli Zaretskii
  2021-01-04 17:06 ` Glenn Morris
  1 sibling, 0 replies; 3+ messages in thread
From: Eli Zaretskii @ 2020-05-03 17:36 UTC (permalink / raw)
  To: Glenn Morris; +Cc: emacs-devel

> From: Glenn Morris <rgm@gnu.org>
> Date: Sun, 03 May 2020 13:20:09 -0400
> 
> A more efficient way to do this would be:
> 1) emacs-27: do something
> 2) emacs-27: revert something, and mark "do not merge to master"
> 
> Then no special handling is needed. 

Thanks, will keep this in mind.



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Procedure for reverting commits on release branch
  2020-05-03 17:20 Procedure for reverting commits on release branch Glenn Morris
  2020-05-03 17:36 ` Eli Zaretskii
@ 2021-01-04 17:06 ` Glenn Morris
  1 sibling, 0 replies; 3+ messages in thread
From: Glenn Morris @ 2021-01-04 17:06 UTC (permalink / raw)
  To: emacs-devel


A reminder about this issue, which happened again with recent AIX changes:

https://lists.gnu.org/r/emacs-devel/2020-05/msg00433.html

If a commit is made on the release branch, and then one wants to instead
have it only on master, then given the following commit sequence:

1) emacs-27: do something
2) emacs-27: revert something
3) master: do something

If gitmerge.el is now used to merge emacs-27 to master:
commit 1) is skipped, because it is already on master
commit 2) is merged

Net result: 3) is reverted on master and has to be applied again by hand.


A more efficient way to do this would be:
1) emacs-27: do something
2) emacs-27: revert something, and mark "do not merge to master"

Then no special handling is needed. 



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-01-04 17:06 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-03 17:20 Procedure for reverting commits on release branch Glenn Morris
2020-05-03 17:36 ` Eli Zaretskii
2021-01-04 17:06 ` Glenn Morris

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).