unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Re: [elpa] externals/emms 0593926d4a: * emms.el: Declare that `define-emms-source' is a defining form
       [not found] ` <20240227055754.77D36C56F2A@vcs2.savannah.gnu.org>
@ 2024-02-27 12:55   ` Stefan Monnier
  2024-02-27 16:56     ` Daniel Semyonov
  0 siblings, 1 reply; 2+ messages in thread
From: Stefan Monnier @ 2024-02-27 12:55 UTC (permalink / raw)
  To: Daniel Semyonov; +Cc: emacs-devel

> commit 0593926d4ad957b9c6f5a9c32f3b4c98b27d239f
> Author: Daniel Semyonov <daniel@dsemy.com>
> Commit: Daniel Semyonov <daniel@dsemy.com>
>
>     * emms.el: Declare that `define-emms-source' is a defining form
>     
>     Allows instrumenting created sources with Edebug and jumping to the
>     definition from help buffers.
>     Also declare 'defun' indentation and that a string as the third
>     argument is a docstring.

The patch looks nice, but I can't see which part allows "jumping to the
definition from help buffers".


        Stefan




^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [elpa] externals/emms 0593926d4a: * emms.el: Declare that `define-emms-source' is a defining form
  2024-02-27 12:55   ` [elpa] externals/emms 0593926d4a: * emms.el: Declare that `define-emms-source' is a defining form Stefan Monnier
@ 2024-02-27 16:56     ` Daniel Semyonov
  0 siblings, 0 replies; 2+ messages in thread
From: Daniel Semyonov @ 2024-02-27 16:56 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: emacs-devel

>>>>> Stefan Monnier writes:

    >> * emms.el: Declare that `define-emms-source' is a defining form
    >> 
    >> Allows instrumenting created sources with Edebug and jumping to the
    >> definition from help buffers.
    >> Also declare 'defun' indentation and that a string as the third
    >> argument is a docstring.

    > The patch looks nice, but I can't see which part allows "jumping to the
    > definition from help buffers".

I was under the impression that setting a defining form's name with a
`&name' element in its debug spec list has this effect, but I just
re-read the documentation and it doesn't mention this.

Daniel



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-02-27 16:56 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <170901347407.20478.2574431549641911659@vcs2.savannah.gnu.org>
     [not found] ` <20240227055754.77D36C56F2A@vcs2.savannah.gnu.org>
2024-02-27 12:55   ` [elpa] externals/emms 0593926d4a: * emms.el: Declare that `define-emms-source' is a defining form Stefan Monnier
2024-02-27 16:56     ` Daniel Semyonov

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).