Re: scratch/igc f433ae8a426: Make x_display_info and xi_device_t amig roots

Re: scratch/igc f433ae8a426: Make x_display_info and xi_device_t amig roots

[Po Lu]

Gerd Moellmann <gerd@gnu.org> writes:

> branch: scratch/igc
> commit f433ae8a4261e1a6a86038316553c7d61300aab7
> Author: Helmut Eller <eller.helmut@gmail.com>
> Commit: Gerd Möllmann <gerd@gnu.org>
>
>     Make x_display_info and xi_device_t amig roots
>     
>     * src/xterm.c (x_cache_xi_devices, xi_disable_devices): Use
>       igc_xzalloc_ambig for xi_disable_t.
>       (handle_one_xevent): For the XI_HierarchyChanged event
>       igc_realloc_ambig if needed.
>       (x_term_init): Use igc_xzalloc_ambig for dpyinfo.
>     * src/igc.h (igc_realloc_ambig): New.
>     * src/igc.c (igc_realloc_ambig): Not implemented yet;
>       scetch of an implementation as comment.

Incidentally, the initial characters of lines in a commit log message
should never be indented.  Improperly formatted messages are tolerated
on scratch branches, as is force-pushing and French punctuation, but
once this code is being merged to master it will be necessary to write
correctly-formatted commit messages and rework the commentary for
English punctuation, i.e. no spacing around punctuation characters
themselves, but two spaces after sentence stops.  It would be far easier
on all concerned if you begin to observe these conventions while the
code is still on a separate branch.

Thanks.