From: raman <raman@google.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Dmitri Paduchikh <dpaduchikh@gmail.com>, emacs-devel@gnu.org
Subject: Re: Brittleness of called-interactively-p
Date: Fri, 17 Jul 2015 11:10:13 -0700 [thread overview]
Message-ID: <p911tg6bqpm.fsf@google.com> (raw)
In-Reply-To: <jwv615jsomb.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Thu, 16 Jul 2015 18:55:29 -0400")
Hi Stefan,
You're right that the two transitions -- called-interactively-p and
nadvice happened at around the same time. However emacspeak still uses
advice.el, not nadvice.el.
I dont quite remember the error pattern that caused me to create the
implementation of ems-interactive-p that I posted, but there was
definitely a bizarre error that things like ruby-mode triggered.
Trying to reconstruct from memory:
Certain edit actions in ruby-mode called backward-sexp
(non-interactively of course)..
The spoken feedback emacspeak generated on those edit actions also
relied on calling backward-sexp (again, non-interactively) to compute
what to speak. Somewhere in all of that, I got an error from one of the
new advice related functions --
--
next prev parent reply other threads:[~2015-07-17 18:10 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-12 5:00 Brittleness of called-interactively-p Dmitri Paduchikh
2015-07-12 13:53 ` Stefan Monnier
2015-07-12 15:17 ` Dmitri Paduchikh
2015-07-12 23:26 ` Stefan Monnier
2015-07-13 15:17 ` Dmitri Paduchikh
2015-07-14 23:24 ` Stefan Monnier
2015-07-16 15:57 ` raman
2015-07-16 17:36 ` Drew Adams
2015-07-16 17:58 ` T.V Raman
2015-07-17 1:55 ` Richard Stallman
2015-07-17 4:52 ` Dmitri Paduchikh
2015-07-17 13:36 ` Dmitri Paduchikh
[not found] ` <jwvpp3qp9dn.fsf-monnier+emacs@gnu.org>
2015-07-18 5:16 ` Dmitri Paduchikh
2015-07-17 18:15 ` raman
2015-07-17 18:14 ` raman
2015-07-17 19:31 ` Drew Adams
2015-07-17 23:25 ` raman
2015-07-18 1:47 ` Drew Adams
2015-07-20 12:19 ` Andreas Röhler
2015-07-16 22:55 ` Stefan Monnier
2015-07-17 18:10 ` raman [this message]
2015-07-18 0:57 ` Stefan Monnier
2015-07-18 4:39 ` Dmitri Paduchikh
2015-07-20 12:22 ` Andreas Röhler
2015-07-20 22:23 ` Stefan Monnier
2015-08-06 22:30 ` Stefan Monnier
2015-08-06 22:33 ` Stefan Monnier
2015-08-07 13:35 ` Dmitri Paduchikh
2015-08-07 17:18 ` Stefan Monnier
2015-07-18 22:29 ` raman
2015-07-12 21:59 ` Richard Stallman
2015-07-13 15:17 ` Dmitri Paduchikh
2015-07-13 23:03 ` Richard Stallman
2015-08-06 22:36 ` Stefan Monnier
2015-07-17 20:35 ` Przemysław Wojnowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=p911tg6bqpm.fsf@google.com \
--to=raman@google.com \
--cc=dpaduchikh@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).