SELinux Bug report

SELinux Bug report

[Bryan Shell]

[-- Attachment #1.1: Type: text/plain, Size: 466 bytes --]

Hi,

I've been have issues the current trunk and the SELinux patch(s) that were
recently applied.  I'm not 100% who's issue it is but it's clear that
configuring with --without-selinux fixes the issue.  I've captured a
backtrace (and have the core file if more information is needed) and have
attached that.  The box I'm useing this on has a rather restrictive policy
in place, so I'm not ruling out the possiblity that it just a configuration
issue.

Thanks
-bryan

[-- Attachment #1.2: Type: text/html, Size: 518 bytes --]

[-- Attachment #2: bt.txt --]
[-- Type: text/plain, Size: 7754 bytes --]

Core was generated by `/home/bshell/projects/emacs-bzr/src/bootstrap-emacs -batch --no-site-file --mul'.
Program terminated with signal 11, Segmentation fault.
#0  0x00ee9410 in __kernel_vsyscall ()
#1  0x003e2226 in kill () from /lib/libc.so.6
#2  0x0811dc9f in fatal_error_signal (sig=11) at emacs.c:402
#3  <signal handler called>
#4  0x004290c3 in strlen () from /lib/libc.so.6
#5  0x081746a2 in build_string (str=0x0) at alloc.c:2461
#6  0x0814d437 in Ffile_selinux_context (filename=139186521) at fileio.c:2924
#7  0x081892ba in Feval (form=141101118) at eval.c:2368
#8  0x0818bd03 in Flet (args=141101078) at eval.c:1074
#9  0x081894bd in Feval (form=141101438) at eval.c:2315
#10 0x0818badf in internal_lisp_condition_case (var=138996994, bodyform=141101438, 
    handlers=141097566) at eval.c:1457
#11 0x0818bb6b in Fcondition_case (args=141101446) at eval.c:1398
#12 0x081894bd in Feval (form=141101454) at eval.c:2315
#13 0x081894bd in Feval (form=141101470) at eval.c:2315
#14 0x0818969f in Fprogn (args=3) at eval.c:415
#15 0x0818bdab in Flet (args=141101638) at eval.c:1090
#16 0x081894bd in Feval (form=141101702) at eval.c:2315
#17 0x081894bd in Feval (form=141101934) at eval.c:2315
#18 0x0818969f in Fprogn (args=3) at eval.c:415
#19 0x08189934 in funcall_lambda (fun=141097520, nargs=0, arg_vector=0xbf83d340) at eval.c:3207
#20 0x08189a56 in apply_lambda (fun=141097526, args=138996994, eval_flag=1) at eval.c:3138
#21 0x08189102 in Feval (form=139929566) at eval.c:2410
#22 0x0818954f in Fsetq (args=139929726) at eval.c:517
#23 0x081894bd in Feval (form=139929862) at eval.c:2315
#24 0x0818c0ec in For (args=3) at eval.c:311
#25 0x081894bd in Feval (form=139930126) at eval.c:2315
#26 0x0818969f in Fprogn (args=3) at eval.c:415
#27 0x0818bdab in Flet (args=139862046) at eval.c:1090
#28 0x081894bd in Feval (form=139862070) at eval.c:2315
#29 0x0818969f in Fprogn (args=3) at eval.c:415
#30 0x08189934 in funcall_lambda (fun=140001896, nargs=0, arg_vector=0xbf83d660) at eval.c:3207
#31 0x08189a56 in apply_lambda (fun=140001902, args=138996994, eval_flag=1) at eval.c:3138
#32 0x08189102 in Feval (form=139862262) at eval.c:2410
#33 0x0818969f in Fprogn (args=3) at eval.c:415
#34 0x081894bd in Feval (form=139833574) at eval.c:2315
#35 0x0818965a in Fprog1 (args=139862246) at eval.c:446
#36 0x081894bd in Feval (form=139841134) at eval.c:2315
#37 0x0818969f in Fprogn (args=3) at eval.c:415
#38 0x08189934 in funcall_lambda (fun=139862112, nargs=0, arg_vector=0xbf83d8a0) at eval.c:3207
#39 0x08189a56 in apply_lambda (fun=139862118, args=138996994, eval_flag=1) at eval.c:3138
#40 0x08189102 in Feval (form=139826798) at eval.c:2410
#41 0x0818954f in Fsetq (args=139826806) at eval.c:517
#42 0x081894bd in Feval (form=139826958) at eval.c:2315
#43 0x0818c0ec in For (args=3) at eval.c:311
#44 0x081894bd in Feval (form=139805134) at eval.c:2315
#45 0x0818969f in Fprogn (args=3) at eval.c:415
#46 0x0817ea06 in Fsave_restriction (body=140090486) at editfns.c:3366
#47 0x081894bd in Feval (form=140090510) at eval.c:2315
#48 0x0818969f in Fprogn (args=3) at eval.c:415
#49 0x0818bdab in Flet (args=140073926) at eval.c:1090
#50 0x081894bd in Feval (form=140077270) at eval.c:2315
#51 0x081894bd in Feval (form=140077294) at eval.c:2315
#52 0x0818969f in Fprogn (args=3) at eval.c:415
#53 0x0817e766 in Fsave_current_buffer (args=140077430) at editfns.c:1028
#54 0x081894bd in Feval (form=140077846) at eval.c:2315
#55 0x0818969f in Fprogn (args=3) at eval.c:415
#56 0x08189934 in funcall_lambda (fun=139841312, nargs=0, arg_vector=0xbf83dda0) at eval.c:3207
#57 0x08189a56 in apply_lambda (fun=139841318, args=138996994, eval_flag=1) at eval.c:3138
#58 0x08189102 in Feval (form=139933702) at eval.c:2410
#59 0x0818969f in Fprogn (args=3) at eval.c:415
#60 0x0818bdab in Flet (args=139933926) at eval.c:1090
#61 0x081894bd in Feval (form=139934142) at eval.c:2315
#62 0x0818969f in Fprogn (args=3) at eval.c:415
#63 0x08189934 in funcall_lambda (fun=139976536, nargs=0, arg_vector=0xbf83dff4) at eval.c:3207
#64 0x08189c6b in Ffuncall (nargs=1, args=0xbf83dff0) at eval.c:3084
#65 0x081bf140 in Fbyte_code (bytestr=178546801, vector=143944021, maxdepth=28) at bytecode.c:680
#66 0x08189848 in funcall_lambda (fun=143944365, nargs=28, arg_vector=0xbf83e124) at eval.c:3214
#67 0x08189c6b in Ffuncall (nargs=29, args=0xbf83e120) at eval.c:3084
#68 0x0818b698 in Fapply (nargs=2, args=0xbf83e244) at eval.c:2525
#69 0x08189f95 in Ffuncall (nargs=3, args=0xbf83e240) at eval.c:3008
#70 0x081bf140 in Fbyte_code (bytestr=178548089, vector=144076637, maxdepth=16) at bytecode.c:680
#71 0x08189848 in funcall_lambda (fun=144076901, nargs=0, arg_vector=0xbf83e374) at eval.c:3214
#72 0x08189c6b in Ffuncall (nargs=1, args=0xbf83e370) at eval.c:3084
#73 0x0818949b in Feval (form=141518678) at eval.c:2341
#74 0x0818969f in Fprogn (args=3) at eval.c:415
#75 0x081894bd in Feval (form=141518622) at eval.c:2315
#76 0x0818969f in Fprogn (args=3) at eval.c:415
#77 0x081894bd in Feval (form=141518094) at eval.c:2315
#78 0x0818969f in Fprogn (args=3) at eval.c:415
#79 0x0818bf45 in FletX (args=141519350) at eval.c:1034
#80 0x081894bd in Feval (form=141519262) at eval.c:2315
#81 0x0818969f in Fprogn (args=3) at eval.c:415
#82 0x0818bba9 in Fwhile (args=141519254) at eval.c:1112
#83 0x081894bd in Feval (form=141519246) at eval.c:2315
#84 0x0818969f in Fprogn (args=3) at eval.c:415
#85 0x0818bdab in Flet (args=141518918) at eval.c:1090
#86 0x081894bd in Feval (form=141520582) at eval.c:2315
#87 0x0818969f in Fprogn (args=3) at eval.c:415
#88 0x081894bd in Feval (form=178479686) at eval.c:2315
#89 0x081894bd in Feval (form=178479710) at eval.c:2315
#90 0x08189414 in Feval (form=141520566) at eval.c:2426
#91 0x0818969f in Fprogn (args=3) at eval.c:415
#92 0x0818bdab in Flet (args=141520558) at eval.c:1090
#93 0x081894bd in Feval (form=141520518) at eval.c:2315
#94 0x0818969f in Fprogn (args=3) at eval.c:415
#95 0x08189934 in funcall_lambda (fun=141513656, nargs=1, arg_vector=0xbf83ea40) at eval.c:3207
#96 0x08189a56 in apply_lambda (fun=141513662, args=141451030, eval_flag=1) at eval.c:3138
#97 0x08189102 in Feval (form=141451006) at eval.c:2410
#98 0x0818969f in Fprogn (args=3) at eval.c:415
#99 0x08189934 in funcall_lambda (fun=141449528, nargs=0, arg_vector=0xbf83eb60) at eval.c:3207
#100 0x08189a56 in apply_lambda (fun=141449534, args=138996994, eval_flag=1) at eval.c:3138
#101 0x08189102 in Feval (form=141317566) at eval.c:2410
#102 0x0818a572 in Funwind_protect (args=141317574) at eval.c:1354
#103 0x081894bd in Feval (form=141317558) at eval.c:2315
#104 0x0818969f in Fprogn (args=3) at eval.c:415
#105 0x0818bdab in Flet (args=141317550) at eval.c:1090
#106 0x081894bd in Feval (form=141317518) at eval.c:2315
#107 0x0818969f in Fprogn (args=3) at eval.c:415
#108 0x081894bd in Feval (form=141318302) at eval.c:2315
#109 0x0818969f in Fprogn (args=3) at eval.c:415
#110 0x08189934 in funcall_lambda (fun=141317080, nargs=0, arg_vector=0xbf83ee80) at eval.c:3207
#111 0x08189a56 in apply_lambda (fun=141317086, args=138996994, eval_flag=1) at eval.c:3138
#112 0x08189102 in Feval (form=139932470) at eval.c:2410
#113 0x08123d93 in top_level_2 () at keyboard.c:1365
#114 0x08188742 in internal_condition_case (bfun=0x8123d80 <top_level_2>, handlers=139027834, 
    hfun=0x8128040 <cmd_error>) at eval.c:1512
#115 0x08127dd0 in top_level_1 () at keyboard.c:1373
#116 0x081887fa in internal_catch (tag=139025954, func=0x8127da0 <top_level_1>, arg=138996994)
    at eval.c:1248
#117 0x08127e79 in command_loop () at keyboard.c:1328
#118 0x0812820b in recursive_edit_1 () at keyboard.c:950
#119 0x08128341 in Frecursive_edit () at keyboard.c:1012
#120 0x0811d000 in main (argc=38, argv=0xbf83f5b4) at emacs.c:1784

Re: SELinux Bug report

[Karel Klic]

[-- Attachment #1: Type: text/plain, Size: 648 bytes --]

Hi Bryan,

the attached patch fixes the crash. Until now I have never seen 
context_*_get() returning NULL.

Karel

On 04/29/2010 11:03 PM, Bryan Shell wrote:
> Hi,
>
> I've been have issues the current trunk and the SELinux patch(s) that
> were recently applied.  I'm not 100% who's issue it is but it's clear
> that configuring with --without-selinux fixes the issue.  I've captured
> a backtrace (and have the core file if more information is needed) and
> have attached that.  The box I'm useing this on has a rather restrictive
> policy in place, so I'm not ruling out the possiblity that it just a
> configuration issue.
>
> Thanks
> -bryan


[-- Attachment #2: emacs-selinux-getnull.patch --]
[-- Type: text/x-patch, Size: 864 bytes --]

--- fileio.c.old	2010-04-30 16:01:40.955759605 +0200
+++ fileio.c	2010-04-30 16:03:45.949877364 +0200
@@ -2918,10 +2918,14 @@
       if (conlength > 0)
 	{
 	  context = context_new (con);
-	  values[0] = build_string (context_user_get (context));
-	  values[1] = build_string (context_role_get (context));
-	  values[2] = build_string (context_type_get (context));
-	  values[3] = build_string (context_range_get (context));
+	  if (context_user_get (context))
+	    values[0] = build_string (context_user_get (context));
+	  if (context_role_get (context))
+	    values[1] = build_string (context_role_get (context));
+	  if (context_type_get (context))
+	    values[2] = build_string (context_type_get (context));
+	  if (context_range_get (context))
+	    values[3] = build_string (context_range_get (context));
 	  context_free (context);
 	}
       if (con)

Re: SELinux Bug report

[Bryan Shell]

[-- Attachment #1: Type: text/plain, Size: 841 bytes --]

Hi Karel,

I've used that patch all day today and it seemed to work fine.

Thanks
-bryan

On Fri, Apr 30, 2010 at 09:12, Karel Klic <kklic@redhat.com> wrote:

> Hi Bryan,
>
> the attached patch fixes the crash. Until now I have never seen
> context_*_get() returning NULL.
>
> Karel
>
>
> On 04/29/2010 11:03 PM, Bryan Shell wrote:
>
>> Hi,
>>
>> I've been have issues the current trunk and the SELinux patch(s) that
>> were recently applied.  I'm not 100% who's issue it is but it's clear
>> that configuring with --without-selinux fixes the issue.  I've captured
>> a backtrace (and have the core file if more information is needed) and
>> have attached that.  The box I'm useing this on has a rather restrictive
>> policy in place, so I'm not ruling out the possiblity that it just a
>> configuration issue.
>>
>> Thanks
>> -bryan
>>
>
>

[-- Attachment #2: Type: text/html, Size: 1406 bytes --]