bootstrap fails in kbd_buffer_get_event

bootstrap fails in kbd_buffer_get_event

[Stephen Berman]

Justed updated from the trunk, bootstrap fails:

keyboard.o: In function `kbd_buffer_get_event':
/home/steve/bzr/emacs/quickfixes/src/keyboard.c:3957: undefined reference to `xd_read_queued_messages'
collect2: ld returned 1 exit status
make[2]: *** [temacs] Error 1
make[2]: Leaving directory `/data/steve/lib/emacs/gtk/src'
make[1]: *** [src] Error 2
make[1]: Leaving directory `/data/steve/lib/emacs/gtk'
make: *** [bootstrap] Error 2

I guess it's due to this change:

2010-10-08  Michael Albinus  <michael.albinus@gmx.de>

	* dbusbind.c (syms_of_dbusbind): Use putenv instead of setenv, it
	is more portable.

	* keyboard.c (gobble_input): Move call of xd_read_queued_messages ...
	(kbd_buffer_get_event): ... here. This is needed for cygwin, which
	has not defined SIGIO.

Steve Berman

Re: bootstrap fails in kbd_buffer_get_event

[Michael Albinus]

Stephen Berman <stephen.berman@gmx.net> writes:

> Justed updated from the trunk, bootstrap fails:
>
> I guess it's due to this change:
>
> 2010-10-08  Michael Albinus  <michael.albinus@gmx.de>
>
> 	* keyboard.c (gobble_input): Move call of xd_read_queued_messages ...
> 	(kbd_buffer_get_event): ... here. This is needed for cygwin, which
> 	has not defined SIGIO.

I've reverted this change; it was synchronized accidently with the trunk
from emacs-23.

> Steve Berman

Best regards, Michael.

Re: bootstrap fails in kbd_buffer_get_event

[Juanma Barranquero]

On Fri, Oct 8, 2010 at 14:44, Michael Albinus <michael.albinus@gmx.de> wrote:

> I've reverted this change; it was synchronized accidently with the trunk
> from emacs-23.

Yes, my fault. Sorry. It is often difficult to know which changes in
emacs-23 are not intended for the trunk.

Perhaps notes in the ChangeLog entries would be a good idea?

    Juanma

Re: bootstrap fails in kbd_buffer_get_event

[Michael Albinus]

Juanma Barranquero <lekktu@gmail.com> writes:

> On Fri, Oct 8, 2010 at 14:44, Michael Albinus <michael.albinus@gmx.de> wrote:
>
>> I've reverted this change; it was synchronized accidently with the trunk
>> from emacs-23.
>
> Yes, my fault. Sorry. It is often difficult to know which changes in
> emacs-23 are not intended for the trunk.

Yes, I know. Especially with D-Bus, there were incompatible changes in
parallel in both the emacs-23 branch, and in the trunk. OTOH, I've
thought it is obvious, because I have moved code which didn't exist in
the trunk anymore ...

> Perhaps notes in the ChangeLog entries would be a good idea?

Good idea. I try to remember next time.

>     Juanma

Best regards (and thanks for all this boring synchronization work!), Michael.

Re: bootstrap fails in kbd_buffer_get_event

[Juanma Barranquero]

On Fri, Oct 8, 2010 at 15:09, Michael Albinus <michael.albinus@gmx.de> wrote:

> OTOH, I've
> thought it is obvious, because I have moved code which didn't exist in
> the trunk anymore ...

I suppose I just wasn't paying enough attention :-(

    Juanma