Re: [Emacs-diffs] trunk r116878: Sync with upstream vhdl mode v3.35.1

[Glenn Morris <rgm@gnu.org>]

Stefan Monnier wrote:

>>  ;; function for expanding abbrevs and dabbrevs
>> -(defalias 'vhdl-expand-abbrev (make-hippie-expand-function
>> -			       '(try-expand-dabbrev
>> -				 try-expand-dabbrev-all-buffers
>> -				 vhdl-try-expand-abbrev)))
>> +(defun vhdl-expand-abbrev (arg))
>> +(fset 'vhdl-expand-abbrev (make-hippie-expand-function
>> +			   '(try-expand-dabbrev
>> +			     try-expand-dabbrev-all-buffers
>> +			     vhdl-try-expand-abbrev)))
>
> Why??!?!

Yes, that made no sense to me either.
I meant to think about it before committing, then forgot.
My random guess would be compat with old Emacs versions.

This is how the code used to be prior to Emacs trunk r108403.
There's no ChangeLog information associated with that commit.
Knowing why it was changed that time would have helped.