From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] trunk r116878: Sync with upstream vhdl mode v3.35.1 Date: Wed, 26 Mar 2014 11:56:16 -0400 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1395849377 4235 80.91.229.3 (26 Mar 2014 15:56:17 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 26 Mar 2014 15:56:17 +0000 (UTC) Cc: Reto Zimmermann , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Mar 26 16:56:26 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WSqBk-0005RV-Rf for ged-emacs-devel@m.gmane.org; Wed, 26 Mar 2014 16:56:24 +0100 Original-Received: from localhost ([::1]:48825 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WSqBk-0003Ji-AH for ged-emacs-devel@m.gmane.org; Wed, 26 Mar 2014 11:56:24 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48951) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WSqBg-0003H2-Py for emacs-devel@gnu.org; Wed, 26 Mar 2014 11:56:21 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WSqBf-0006di-WB for emacs-devel@gnu.org; Wed, 26 Mar 2014 11:56:20 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:57225) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WSqBf-0006de-Sm for emacs-devel@gnu.org; Wed, 26 Mar 2014 11:56:19 -0400 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1WSqBc-0007Uz-Mw; Wed, 26 Mar 2014 11:56:16 -0400 X-Spook: ARPA munitions Plame Israel Tony Blair BCCI emc virus X-Ran: #Zp'K7=uO~BG%Nfqy=_ (Stefan Monnier's message of "Wed, 26 Mar 2014 08:49:59 -0400") User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:171008 Archived-At: Stefan Monnier wrote: >> ;; function for expanding abbrevs and dabbrevs >> -(defalias 'vhdl-expand-abbrev (make-hippie-expand-function >> - '(try-expand-dabbrev >> - try-expand-dabbrev-all-buffers >> - vhdl-try-expand-abbrev))) >> +(defun vhdl-expand-abbrev (arg)) >> +(fset 'vhdl-expand-abbrev (make-hippie-expand-function >> + '(try-expand-dabbrev >> + try-expand-dabbrev-all-buffers >> + vhdl-try-expand-abbrev))) > > Why??!?! Yes, that made no sense to me either. I meant to think about it before committing, then forgot. My random guess would be compat with old Emacs versions. This is how the code used to be prior to Emacs trunk r108403. There's no ChangeLog information associated with that commit. Knowing why it was changed that time would have helped.