unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Re: master updated (eeb6d9d -> 56254fb)
       [not found] <20210914112823.17846.80285@vcs0.savannah.gnu.org>
@ 2021-09-14 15:10 ` Glenn Morris
  2021-09-14 17:31   ` João Távora
  0 siblings, 1 reply; 5+ messages in thread
From: Glenn Morris @ 2021-09-14 15:10 UTC (permalink / raw)
  To: emacs-devel; +Cc: joaotavora


Hi,

Something in this appears not to bootstrap.
Ref eg https://hydra.nixos.org/build/152903587

 progmodes/elisp-mode.el:2001:1: Error: Symbol's function definition is
 void: cl-subseq



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: master updated (eeb6d9d -> 56254fb)
  2021-09-14 15:10 ` master updated (eeb6d9d -> 56254fb) Glenn Morris
@ 2021-09-14 17:31   ` João Távora
  2021-09-14 18:24     ` João Távora
  0 siblings, 1 reply; 5+ messages in thread
From: João Távora @ 2021-09-14 17:31 UTC (permalink / raw)
  To: Glenn Morris; +Cc: emacs-devel

[-- Attachment #1: Type: text/plain, Size: 418 bytes --]

Ugh, this is horrible.

What can it be, if I haven't touched that file? Some macroexpansion failure?

 I'll have a look.
João



On Tue, Sep 14, 2021, 16:52 Glenn Morris <rgm@gnu.org> wrote:

>
> Hi,
>
> Something in this appears not to bootstrap.
> Ref eg https://hydra.nixos.org/build/152903587
>
>  progmodes/elisp-mode.el:2001:1: Error: Symbol's function definition is
>  void: cl-subseq
>
>

[-- Attachment #2: Type: text/html, Size: 1479 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: master updated (eeb6d9d -> 56254fb)
  2021-09-14 17:31   ` João Távora
@ 2021-09-14 18:24     ` João Távora
  2021-09-14 18:32       ` João Távora
  0 siblings, 1 reply; 5+ messages in thread
From: João Távora @ 2021-09-14 18:24 UTC (permalink / raw)
  To: Glenn Morris; +Cc: emacs-devel

João Távora <joaotavora@gmail.com> writes:

> Ugh, this is horrible. 
>
> What can it be, if I haven't touched that file? Some macroexpansion failure?
>
>  I'll have a look.
> João

I've bisected this to the culprit commit

    commit 404023299429a2619c6e4bc5da80eb248d060ef9
    Author: João Távora <joaotavora@gmail.com>
    Date:   Tue Aug 31 18:43:12 2021 +0100
     
        Refactor some Flymake functions

I think it has to do with using cl-defun and &aux parameters.  Checking.

João



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: master updated (eeb6d9d -> 56254fb)
  2021-09-14 18:24     ` João Távora
@ 2021-09-14 18:32       ` João Távora
  2021-09-14 21:52         ` Glenn Morris
  0 siblings, 1 reply; 5+ messages in thread
From: João Távora @ 2021-09-14 18:32 UTC (permalink / raw)
  To: Glenn Morris; +Cc: emacs-devel

João Távora <joaotavora@gmail.com> writes:

> João Távora <joaotavora@gmail.com> writes:
>
>> Ugh, this is horrible. 
>>
>> What can it be, if I haven't touched that file? Some macroexpansion failure?
>>
>>  I'll have a look.
>> João
>
> I've bisected this to the culprit commit
>
>     commit 404023299429a2619c6e4bc5da80eb248d060ef9
>     Author: João Távora <joaotavora@gmail.com>
>     Date:   Tue Aug 31 18:43:12 2021 +0100
>      
>         Refactor some Flymake functions
>
> I think it has to do with using cl-defun and &aux parameters.  Checking.

Yes.  That was it.  Fixed in 55dda2571a829fcff7e04d83818150d7c0002f7a.
Seems we can't use cl-defun and &aux, or at least &aux with default
values.

João



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: master updated (eeb6d9d -> 56254fb)
  2021-09-14 18:32       ` João Távora
@ 2021-09-14 21:52         ` Glenn Morris
  0 siblings, 0 replies; 5+ messages in thread
From: Glenn Morris @ 2021-09-14 21:52 UTC (permalink / raw)
  To: João Távora; +Cc: emacs-devel


Thanks for fixing it!




^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-09-14 21:52 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20210914112823.17846.80285@vcs0.savannah.gnu.org>
2021-09-14 15:10 ` master updated (eeb6d9d -> 56254fb) Glenn Morris
2021-09-14 17:31   ` João Távora
2021-09-14 18:24     ` João Távora
2021-09-14 18:32       ` João Távora
2021-09-14 21:52         ` Glenn Morris

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).