unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: storm@cua.dk (Kim F. Storm)
Cc: emacs-devel@gnu.org
Subject: Re: font-lock-negation-char-face
Date: Sat, 07 May 2005 22:17:42 +0200	[thread overview]
Message-ID: <m3zmv6g595.fsf@kfs-l.imdomain.dk> (raw)
In-Reply-To: <01c552eb$Blat.v2.4$45f05e20@zahav.net.il> (Eli Zaretskii's message of "Sat, 07 May 2005 12:57:06 +0300")

"Eli Zaretskii" <eliz@gnu.org> writes:

>> From: Henrik Enberg <henrik.enberg@telia.com>
>> Date: Sat, 07 May 2005 08:15:59 +0200
>> Cc: emacs-devel@gnu.org
>> 
>> Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> 
>> > Let me just say that I find this new "feature" dubious.
>> > - it makes things even more "angry fruit salad" and thus requires
>> >   yet more tweaking to make the text legible again.
>> > - it's unclear that these specific chars are particular sources of errors.
>> > - why not have a more generic name like font-lock-important-detail-face,
>> >   so it's at least not so absurdly narrow-scoped.
>> 
>> Indeed, I find that it makes my code much harder to read.  The choice of
>> a bold face as default is especially bad.  And as you say, I don't
>> really think people write !foo erroneously all that often.
>
> Let me join the choir and say that the effect of this change is
> unpleasant at best, IMO.  I think this new feature should be at least
> turned off by default, if not removed.

And it makes wrong highlights too, e.g. the '!' in the following line:

  xassert (s != NULL);


When was this new feature discussed?

-- 
Kim F. Storm <storm@cua.dk> http://www.cua.dk

  reply	other threads:[~2005-05-07 20:17 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-06 22:32 font-lock-negation-char-face Stefan Monnier
2005-05-07  6:15 ` font-lock-negation-char-face Henrik Enberg
2005-05-07  9:57   ` font-lock-negation-char-face Eli Zaretskii
2005-05-07 20:17     ` Kim F. Storm [this message]
2005-05-08 22:40       ` font-lock-negation-char-face Juanma Barranquero
2005-05-08  9:03     ` font-lock-negation-char-face Richard Stallman
2005-05-08 10:41       ` font-lock-negation-char-face Paul Pogonyshev
2005-05-08 17:33         ` font-lock-negation-char-face Stefan Monnier
2005-05-09  8:57           ` font-lock-negation-char-face Richard Stallman
2005-05-08 22:46         ` font-lock-negation-char-face Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3zmv6g595.fsf@kfs-l.imdomain.dk \
    --to=storm@cua.dk \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).