unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: toke@toke.dk, emacs-devel@gnu.org
Subject: Re: [PATCH] url: Wrap cookie headers in url-http--encode-string.
Date: Thu, 08 Sep 2016 11:07:17 +0200	[thread overview]
Message-ID: <m3zinilpyy.fsf@gnus.org> (raw)
In-Reply-To: <83vay785v6.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 08 Sep 2016 05:47:41 +0300")

Eli Zaretskii <eliz@gnu.org> writes:

> That makes very little sense to me, as it will re-introduce the
> problems which caused us to add the test.  And it's a code change, so
> it will require at least the same amount of testing that whatever fix
> we come up with for this use case.  Sounds like lose-lose to me.

The problems were pretty obscure, since most servers don't care much
about what the length header says.  And removing the error-out has a
very small chance of breaking anything, to put it mildly.

And we have no idea how many of these unencoded parameters remain to be
encoded (because of the rather wonky url calling conventions), so we
could be adding these encoding patches piecemeal to Emacs 25.1 pretests
for the next couple of years (at the current going rate of one per
month) while waiting to find them all.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no



  reply	other threads:[~2016-09-08  9:07 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-07 15:30 [PATCH] url: Wrap cookie headers in url-http--encode-string Toke Høiland-Jørgensen
2016-09-07 16:40 ` Stefan Monnier
2016-09-07 16:52   ` Toke Høiland-Jørgensen
2016-09-07 17:15     ` Eli Zaretskii
2016-09-07 18:25       ` Toke Høiland-Jørgensen
2016-09-08 14:06         ` Dmitry Gutov
2016-09-08 14:14           ` Toke Høiland-Jørgensen
2016-09-08 14:25             ` Dmitry Gutov
2016-09-08 15:58               ` Toke Høiland-Jørgensen
2016-09-08 17:20                 ` Eli Zaretskii
2016-09-08 17:43                   ` Toke Høiland-Jørgensen
2016-09-08 18:01                     ` Eli Zaretskii
2016-09-08 17:47                   ` Stefan Monnier
2016-09-08 18:04                     ` Eli Zaretskii
2016-09-08 20:29                       ` Alain Schneble
2016-09-09  7:57                         ` Eli Zaretskii
2016-09-09 14:56                 ` Alain Schneble
2016-09-09 15:04                   ` Eli Zaretskii
2016-09-09 15:16                     ` Alain Schneble
2016-09-09 15:06                   ` Stefan Monnier
2016-09-09 15:15                     ` Alain Schneble
2016-09-09 18:02                 ` Alain Schneble
2016-09-09 18:07                   ` Toke Høiland-Jørgensen
2016-09-09 18:54                   ` Eli Zaretskii
2016-09-09 19:21                     ` Alain Schneble
2016-09-09 19:32                       ` Eli Zaretskii
2016-09-09 19:47                         ` Alain Schneble
2016-09-09 19:49                           ` Eli Zaretskii
2016-09-09 19:56                             ` Toke Høiland-Jørgensen
2016-09-10  5:42                               ` Eli Zaretskii
2016-09-10  8:34                                 ` Dmitry Gutov
2016-09-10 19:12                                   ` Eli Zaretskii
2016-09-09 20:01                         ` distinguishing multibyte/unibyte ASCII (was: [PATCH] url: Wrap cookie headers in url-http--encode-string.) Stefan Monnier
2016-09-09 20:17                           ` distinguishing multibyte/unibyte ASCII Toke Høiland-Jørgensen
2016-09-09 20:46                             ` Stefan Monnier
2016-09-09 21:02                           ` Alain Schneble
2016-09-10  5:50                           ` distinguishing multibyte/unibyte ASCII (was: [PATCH] url: Wrap cookie headers in url-http--encode-string.) Eli Zaretskii
2016-09-07 19:14 ` [PATCH] url: Wrap cookie headers in url-http--encode-string Lars Ingebrigtsen
2016-09-07 20:49   ` Toke Høiland-Jørgensen
2016-09-08  2:47   ` Eli Zaretskii
2016-09-08  9:07     ` Lars Ingebrigtsen [this message]
2016-09-08 17:23       ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3zinilpyy.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=toke@toke.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).