From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] url: Wrap cookie headers in url-http--encode-string. Date: Thu, 08 Sep 2016 11:07:17 +0200 Message-ID: References: <20160907153014.15752-1-toke@toke.dk> <83vay785v6.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1473342495 25055 195.159.176.226 (8 Sep 2016 13:48:15 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 8 Sep 2016 13:48:15 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) Cc: toke@toke.dk, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Sep 08 15:48:09 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bhzgS-0005PL-6A for ged-emacs-devel@m.gmane.org; Thu, 08 Sep 2016 15:48:04 +0200 Original-Received: from localhost ([::1]:48064 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bhzgP-0003vw-UH for ged-emacs-devel@m.gmane.org; Thu, 08 Sep 2016 09:48:02 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47347) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bhvK8-0006J7-DF for emacs-devel@gnu.org; Thu, 08 Sep 2016 05:08:45 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bhvK5-0004vh-5d for emacs-devel@gnu.org; Thu, 08 Sep 2016 05:08:44 -0400 Original-Received: from hermes.netfonds.no ([80.91.224.195]:55024) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bhvK4-0004vV-J0; Thu, 08 Sep 2016 05:08:41 -0400 Original-Received: from cm-84.215.1.64.getinternet.no ([84.215.1.64] helo=stories) by hermes.netfonds.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1bhvJy-0003ky-NK; Thu, 08 Sep 2016 11:08:38 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAGFBMVEUVCgf90WSySSc2FBAQ BwVlJBvqhjcOBQTQWCAHAAACeUlEQVQ4jVWUy4rkMAxFBXGYdQra624VydqUx/ssDNmmY1z7eIi+ wJDfnyvXo2kVpEAnel3LIep8M6IIO99GBGduJMYlLj/AhayWvItGUfPWpZIPY2YGcWSMeSariMhw q+X0BrWBjScWkcJIRmY2qBIrMHGZRPZDythAXJZYTwUTwGBZ7JicN6R91WqWheT6ZYeLAPjkzfxn OcGWGEkO4akIl5RbFXWf6IFkc+H7KDzRLQPEBTMsM0Dpev7+KGXzfcCQOmKtCq59yPfrmMlUUr3w /qmiUeygHzxLnOcZf6qWhtHpV9/R01AapFYFUBcaQl3niOaXVkukSCnklF1ocSpWPFvEShRCHteU PDmtVatqEmlE7aDZUiankix6JgBlS67zSJXXsD5T6SFT4X3Ug+3TmoPDiSztF+nCu3ygqx7Zeq+n O8cWMckuQ0HpzW85dY7OWeWaCe59sJeUUs9hzSumj4ghGqzdrR3sNeVPtGa8NmAw0jDYXXY8t+2K SUNICDEzEfIM+450QxkzCI6xgx81hkEBTI68JTSnwrRUag/CbSVblReQ9hAer953zsTaaojWeRDU 8WHVjSSs4T48DeBIATPGB5AfYIW3tWuSME8vYGWyRYp7FN9+Ad3J5P9iMygwv4pYJC07Z16Ngu0X wOlsrOpTl98h6Nvy13Ef0TCO/4byb3Dh+8f9nx8/oUm3vTsWGafpmACwO4567Xh/1BjvdpSrHxHg WzJRA+CtZEmBHxvb6fXUqwjARxbc8Ocu30S9GsbTEdjfrrr/s4ndXd8v7b5jydzt8wnm/vE6Y7j8 AhW3sSJZmdr3od1QbBeRfnEw/134B8Dm/1rTAPlBX1HZAAAAAElFTkSuQmCC In-Reply-To: <83vay785v6.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 08 Sep 2016 05:47:41 +0300") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 80.91.224.195 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:207286 Archived-At: Eli Zaretskii writes: > That makes very little sense to me, as it will re-introduce the > problems which caused us to add the test. And it's a code change, so > it will require at least the same amount of testing that whatever fix > we come up with for this use case. Sounds like lose-lose to me. The problems were pretty obscure, since most servers don't care much about what the length header says. And removing the error-out has a very small chance of breaking anything, to put it mildly. And we have no idea how many of these unencoded parameters remain to be encoded (because of the rather wonky url calling conventions), so we could be adding these encoding patches piecemeal to Emacs 25.1 pretests for the next couple of years (at the current going rate of one per month) while waiting to find them all. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no