From: Lars Magne Ingebrigtsen <larsi@gnus.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: emacs-devel@gnu.org
Subject: Re: trunk r113947: * image.c: Fix animation cache signature memory leak.
Date: Mon, 19 Aug 2013 18:19:46 +0200 [thread overview]
Message-ID: <m3vc31ps9p.fsf@stories.gnus.org> (raw)
In-Reply-To: <521244F0.3060508@cs.ucla.edu> (Paul Eggert's message of "Mon, 19 Aug 2013 09:16:48 -0700")
Paul Eggert <eggert@cs.ucla.edu> writes:
>> you didn't test it,
>> because it segfaulted the first time it was called.
>
> I did test it, but evidently not with enough test cases.
> Sorry about the bug.
But it would crash with any (animated) image, because it never allocated
a cache. If I read the code correctly. :-)
> To avoid such problems in the future, should we funnel future
> image.c changes through you?
No no.
> Here's a tiny style issue that should be fixed at some point: the
> version you inserted has "strcmp(" in a couple of places where it
> should be "strcmp (".
No, please go ahead and fix.
--
(domestic pets only, the antidote for overdose, milk.)
No Gnus T-Shirt for sale: http://ingebrigtsen.no/no.php
and http://lars.ingebrigtsen.no/2013/08/twenty-years-of-september.html
next prev parent reply other threads:[~2013-08-19 16:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1VBJTG-0003rv-7A@vcs.savannah.gnu.org>
2013-08-19 15:22 ` trunk r113947: * image.c: Fix animation cache signature memory leak Lars Magne Ingebrigtsen
2013-08-19 16:16 ` Paul Eggert
2013-08-19 16:19 ` Lars Magne Ingebrigtsen [this message]
2013-08-19 16:24 ` Paul Eggert
2013-08-19 16:40 ` Lars Magne Ingebrigtsen
2013-08-19 16:56 ` Paul Eggert
2013-08-19 17:04 ` Lars Magne Ingebrigtsen
2013-08-19 19:46 ` Paul Eggert
2013-08-19 19:51 ` Lars Magne Ingebrigtsen
2013-08-19 20:52 ` Paul Eggert
2013-08-19 20:56 ` Lars Magne Ingebrigtsen
2013-08-19 20:55 ` Lars Magne Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3vc31ps9p.fsf@stories.gnus.org \
--to=larsi@gnus.org \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).