unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Magne Ingebrigtsen <larsi@gnus.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: tzz@lifelogs.com, toke@toke.dk, emacs-devel@gnu.org
Subject: Re: [PATCH RFC] GnuTLS: Support TOFU certificate checking.
Date: Wed, 08 Oct 2014 15:47:33 +0200	[thread overview]
Message-ID: <m3tx3ey8p6.fsf@stories.gnus.org> (raw)
In-Reply-To: <838ukqk7gd.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 08 Oct 2014 16:38:10 +0300")

Eli Zaretskii <eliz@gnu.org> writes:

> What happens if some stuff comes out of the stream that failed to be
> validated, while Emacs negotiates with the user about what to do?
> Normally, we would pass this stuff to whatever sentinel was defined,
> or insert it into a buffer.  Is that what you want?

Does that really happen that early in the connection process?  I thought
sentinels and buffers were attached at a point later, so that
`open-network-stream' would have a chance of inspecting the stream
first.

It's been a while since I looked at the code, so if that's wrong (and
can't be fixed), then we'd have to do it the way you suggest:

> If what you want is to cause gnutls-boot call out to Lisp for
> validation as part of its normal path, then that's fine, I think.  But
> it does mean that we have no stream until the entire validation
> completes. 

However, I was hoping to get the "bug out if the stream isn't encrypted
and you wanted that" into the same code, so it would be nice to have it
all in the same code path.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no



  reply	other threads:[~2014-10-08 13:47 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-07 21:16 [PATCH RFC] GnuTLS: Support TOFU certificate checking Toke Høiland-Jørgensen
2014-10-07 21:35 ` Lars Magne Ingebrigtsen
2014-10-07 21:55   ` Toke Høiland-Jørgensen
2014-10-08 11:53     ` Lars Magne Ingebrigtsen
2014-10-08 11:58       ` Lars Magne Ingebrigtsen
2014-10-08 12:10       ` Toke Høiland-Jørgensen
2014-10-08 12:18         ` Lars Magne Ingebrigtsen
2014-10-08 12:39           ` Toke Høiland-Jørgensen
2014-10-08 12:42             ` Lars Magne Ingebrigtsen
2014-10-08 12:53           ` Eli Zaretskii
2014-10-08 12:56             ` Lars Magne Ingebrigtsen
2014-10-08 13:03               ` Eli Zaretskii
2014-10-08 13:06                 ` Lars Magne Ingebrigtsen
2014-10-08 13:17                   ` Eli Zaretskii
2014-10-08 13:25                     ` Lars Magne Ingebrigtsen
2014-10-08 13:38                       ` Eli Zaretskii
2014-10-08 13:47                         ` Lars Magne Ingebrigtsen [this message]
2014-10-08 13:59                           ` Toke Høiland-Jørgensen
2014-10-08 14:05                             ` Lars Magne Ingebrigtsen
2014-10-08 14:01                           ` Eli Zaretskii
2014-10-08 14:09                             ` Lars Magne Ingebrigtsen
2014-10-08 14:11                               ` Eli Zaretskii
2014-10-08 14:56                               ` Ted Zlatanov
2014-10-08 15:31                                 ` Lars Magne Ingebrigtsen
2014-10-08 15:37                                   ` Ted Zlatanov
2014-10-09  2:43                                     ` Stephen J. Turnbull
2014-10-09 13:17                                       ` Ted Zlatanov
2014-10-08 13:28                   ` Toke Høiland-Jørgensen
2014-10-08 14:52 ` Ted Zlatanov
2014-10-08 15:19   ` Toke Høiland-Jørgensen
2014-10-08 15:45     ` Ted Zlatanov
2014-10-08 16:09       ` Toke Høiland-Jørgensen
2014-10-08 16:52     ` Lars Magne Ingebrigtsen
2014-10-08 17:07       ` Toke Høiland-Jørgensen
2014-10-09 13:10         ` Ted Zlatanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3tx3ey8p6.fsf@stories.gnus.org \
    --to=larsi@gnus.org \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=toke@toke.dk \
    --cc=tzz@lifelogs.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).