unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Toke Høiland-Jørgensen" <toke@toke.dk>
To: emacs-devel@gnu.org
Subject: Re: [PATCH RFC] GnuTLS: Support TOFU certificate checking.
Date: Wed, 08 Oct 2014 18:09:25 +0200	[thread overview]
Message-ID: <87tx3ezgp6.fsf@toke.dk> (raw)
In-Reply-To: <m238ay4lc1.fsf@lifelogs.com> (Ted Zlatanov's message of "Wed, 08 Oct 2014 11:45:02 -0400")

Ted Zlatanov <tzz@lifelogs.com> writes:

> Emacs has this function already, e.g. `(locate-user-emacs-file "certs")'
>
> I think it's better to make the store private than shared by default, so
> I'd just give the user the choice to use nil (translated to NULL in
> C).

Ah, yes, this should come from the lisp side of course. Silly me, hadn't
even thought of that.

> That would be great, please see how far you get with the exploration.
> Your contribution is already very useful so I am excited to see it
> evolve.

Well, gnutls-cli asks the user in a callback (set with
gnutls_certificate_set_verify_function). The TOFU verification starts at
line 461 of
https://gitorious.org/gnutls/gnutls/source/ce47098eecba5fb3256b855f9674ee0ca458c60c:src/cli.c

so it seems it's just pausing in the middle of the handshake.

> OK; Lars and I will probably work on it as well as time allows in
> order to get something into trunk.

Oh, by all means. I didn't mean that as "don't touch it", more as "don't
expect anything more too soon" :)

Have updated the patch to use a configurable credentials file and put in
the autoconf stuff. Will resend it once I have tested it :)

-Toke



  reply	other threads:[~2014-10-08 16:09 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-07 21:16 [PATCH RFC] GnuTLS: Support TOFU certificate checking Toke Høiland-Jørgensen
2014-10-07 21:35 ` Lars Magne Ingebrigtsen
2014-10-07 21:55   ` Toke Høiland-Jørgensen
2014-10-08 11:53     ` Lars Magne Ingebrigtsen
2014-10-08 11:58       ` Lars Magne Ingebrigtsen
2014-10-08 12:10       ` Toke Høiland-Jørgensen
2014-10-08 12:18         ` Lars Magne Ingebrigtsen
2014-10-08 12:39           ` Toke Høiland-Jørgensen
2014-10-08 12:42             ` Lars Magne Ingebrigtsen
2014-10-08 12:53           ` Eli Zaretskii
2014-10-08 12:56             ` Lars Magne Ingebrigtsen
2014-10-08 13:03               ` Eli Zaretskii
2014-10-08 13:06                 ` Lars Magne Ingebrigtsen
2014-10-08 13:17                   ` Eli Zaretskii
2014-10-08 13:25                     ` Lars Magne Ingebrigtsen
2014-10-08 13:38                       ` Eli Zaretskii
2014-10-08 13:47                         ` Lars Magne Ingebrigtsen
2014-10-08 13:59                           ` Toke Høiland-Jørgensen
2014-10-08 14:05                             ` Lars Magne Ingebrigtsen
2014-10-08 14:01                           ` Eli Zaretskii
2014-10-08 14:09                             ` Lars Magne Ingebrigtsen
2014-10-08 14:11                               ` Eli Zaretskii
2014-10-08 14:56                               ` Ted Zlatanov
2014-10-08 15:31                                 ` Lars Magne Ingebrigtsen
2014-10-08 15:37                                   ` Ted Zlatanov
2014-10-09  2:43                                     ` Stephen J. Turnbull
2014-10-09 13:17                                       ` Ted Zlatanov
2014-10-08 13:28                   ` Toke Høiland-Jørgensen
2014-10-08 14:52 ` Ted Zlatanov
2014-10-08 15:19   ` Toke Høiland-Jørgensen
2014-10-08 15:45     ` Ted Zlatanov
2014-10-08 16:09       ` Toke Høiland-Jørgensen [this message]
2014-10-08 16:52     ` Lars Magne Ingebrigtsen
2014-10-08 17:07       ` Toke Høiland-Jørgensen
2014-10-09 13:10         ` Ted Zlatanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tx3ezgp6.fsf@toke.dk \
    --to=toke@toke.dk \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).