Re: FIX: byte-code: Wrong type argument: number-or-marker-p, (+ -21)

[storm@cua.dk (Kim F. Storm)]

Jan Nieuwenhuizen <janneke@gnu.org> writes:

> Jan Nieuwenhuizen <janneke@gnu.org> writes:
> 
> > Ah, so that's what (and why) the strange notation means.  Then it
> > should probably be something like:
> >
> >  (cond ((eq '+ (car fif-top)) (cadr fif-top))
> >        ((eq '- (car fif-top)) (- <DISPLAY-HEIGHT> (cadr fif-top)))
> 
> So here's a new try.
> 
> Jan.
> 
> 2003-11-18  Jan Nieuwenhuizen  <jan.nieuwenhuizen@aspiratie.nl>
> 
> 	* frame.el (frame-notice-user-settings): Fix for TOP parameter
> 	of CONS flavour.
> 
> --- frame.el.~1.205.~	2003-10-02 16:06:45.000000000 +0200
> +++ frame.el	2003-11-18 22:07:36.000000000 +0100
> @@ -333,7 +333,13 @@ React to settings of `default-frame-alis
>  		   (newparms (list (cons 'height (- height lines))))
>  		   (initial-top (cdr (assq 'top
>  					   frame-initial-geometry-arguments)))
> -		   (top (frame-parameter frame-initial-frame 'top)))
> +		   (fif-top (frame-parameter frame-initial-frame 'top))
> +		   (top (if (consp fif-top)
> +			    (cond ((eq '+ (car fif-top)) (cadr fif-top))
> +				  ((eq '- (car fif-top))
> +				   (- (display-pixel-height) (cadr fif-top)))
> +				  (t 0))
> +			  fif-top)))
>  	      (when (and (consp initial-top) (eq '- (car initial-top)))
>  		(setq newparms
>  		      (append newparms
> 

This is definitely better than before, but you still do not address
the issue whether the new setting for top should be top/left or
bottom/right relative, ie. whether the new top value should be (+ INT)
or (- INT) if the old settings had that format (rather than an
integer).

I don't quite know what's the right thing to do.  WDOT?

-- 
Kim F. Storm <storm@cua.dk> http://www.cua.dk