From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: storm@cua.dk (Kim F. Storm) Newsgroups: gmane.emacs.devel Subject: Re: FIX: byte-code: Wrong type argument: number-or-marker-p, (+ -21) Date: 19 Nov 2003 18:07:32 +0100 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: References: <200311142330.hAENUB5p021655@stubby.bodenonline.com> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1069258418 31447 80.91.224.253 (19 Nov 2003 16:13:38 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 19 Nov 2003 16:13:38 +0000 (UTC) Cc: "Jan D." , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Wed Nov 19 17:13:35 2003 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1AMUxT-00073Q-00 for ; Wed, 19 Nov 2003 17:13:35 +0100 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1AMUxT-0007A3-00 for ; Wed, 19 Nov 2003 17:13:35 +0100 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.24) id 1AMVra-0005AH-5v for emacs-devel@quimby.gnus.org; Wed, 19 Nov 2003 12:11:34 -0500 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24) id 1AMVqL-0004QQ-Vr for emacs-devel@gnu.org; Wed, 19 Nov 2003 12:10:17 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24) id 1AMVpb-0003nU-UH for emacs-devel@gnu.org; Wed, 19 Nov 2003 12:10:03 -0500 Original-Received: from [212.88.64.25] (helo=mail-relay.sonofon.dk) by monty-python.gnu.org with smtp (Exim 4.24) id 1AMVpK-0003Yx-ON for emacs-devel@gnu.org; Wed, 19 Nov 2003 12:09:15 -0500 Original-Received: (qmail 23634 invoked from network); 19 Nov 2003 16:07:47 -0000 Original-Received: from unknown (HELO kfs-l.imdomain.dk.cua.dk) (213.83.150.2) by 0 with SMTP; 19 Nov 2003 16:07:47 -0000 Original-To: Jan Nieuwenhuizen In-Reply-To: Original-Lines: 48 User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.2 Precedence: list List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:17923 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:17923 Jan Nieuwenhuizen writes: > Jan Nieuwenhuizen writes: > > > Ah, so that's what (and why) the strange notation means. Then it > > should probably be something like: > > > > (cond ((eq '+ (car fif-top)) (cadr fif-top)) > > ((eq '- (car fif-top)) (- (cadr fif-top))) > > So here's a new try. > > Jan. > > 2003-11-18 Jan Nieuwenhuizen > > * frame.el (frame-notice-user-settings): Fix for TOP parameter > of CONS flavour. > > --- frame.el.~1.205.~ 2003-10-02 16:06:45.000000000 +0200 > +++ frame.el 2003-11-18 22:07:36.000000000 +0100 > @@ -333,7 +333,13 @@ React to settings of `default-frame-alis > (newparms (list (cons 'height (- height lines)))) > (initial-top (cdr (assq 'top > frame-initial-geometry-arguments))) > - (top (frame-parameter frame-initial-frame 'top))) > + (fif-top (frame-parameter frame-initial-frame 'top)) > + (top (if (consp fif-top) > + (cond ((eq '+ (car fif-top)) (cadr fif-top)) > + ((eq '- (car fif-top)) > + (- (display-pixel-height) (cadr fif-top))) > + (t 0)) > + fif-top))) > (when (and (consp initial-top) (eq '- (car initial-top))) > (setq newparms > (append newparms > This is definitely better than before, but you still do not address the issue whether the new setting for top should be top/left or bottom/right relative, ie. whether the new top value should be (+ INT) or (- INT) if the old settings had that format (rather than an integer). I don't quite know what's the right thing to do. WDOT? -- Kim F. Storm http://www.cua.dk