update-game-score

update-game-score

[Eli Zaretskii]

IMHO, this code needs to take non-Posix platforms into consideration,
unless the intent is to run it only on Unix and GNU/Linux systems.

If non-Posix systems are relevant, you should be aware that <pwd.h>
and the getpwuid function are not universally available.  In fact,
AFAIK, getpwuid wasn't even part of Posix until very recently, so some
older Posix systems might not have it as well.  So some
autoconfiscation or system-dependent ifdef's are in order.

Re: update-game-score

[Jason Rumney]

"Eli Zaretskii" <eliz@is.elta.co.il> writes:

> IMHO, this code needs to take non-Posix platforms into consideration,
> unless the intent is to run it only on Unix and GNU/Linux systems.
> 
> If non-Posix systems are relevant, you should be aware that <pwd.h>
> and the getpwuid function are not universally available.

Can getpwuid etc be emulated on MSDOS and Mac as they are on Windows?


-- 
Jason Rumney

Re: update-game-score

[Andrew Choi]

> > IMHO, this code needs to take non-Posix platforms into consideration,
> > unless the intent is to run it only on Unix and GNU/Linux systems.
> > 
> > If non-Posix systems are relevant, you should be aware that <pwd.h>
> > and the getpwuid function are not universally available.
> 
> Can getpwuid etc be emulated on MSDOS and Mac as they are on Windows?

Getpwuid is certainly available on Mac OS X.  Mac OS 9 implements a
limited form of multiple user support, so getpwuid can probably be
emulated on it.  Mac OS 8 does not have multiple user support.  I
suppose one can still emulate getpwuid with a little more effort.

Re: update-game-score

[Jason Rumney]

Andrew Choi <akochoi@shaw.ca> writes:

> Getpwuid is certainly available on Mac OS X.  Mac OS 9 implements a
> limited form of multiple user support, so getpwuid can probably be
> emulated on it.  Mac OS 8 does not have multiple user support.  I
> suppose one can still emulate getpwuid with a little more effort.

If there is no multiple user support, then getpwuid only needs to
emulate one user.  The Windows port also needs to deal with this for
Windows 9x, since only a subset of multi-user functionality is there.

-- 
Jason Rumney

Re: update-game-score

[Eli Zaretskii]

> From: Jason Rumney <jasonr@gnu.org>
> Date: 06 Apr 2002 10:32:23 +0100
> 
> "Eli Zaretskii" <eliz@is.elta.co.il> writes:
> 
> > IMHO, this code needs to take non-Posix platforms into consideration,
> > unless the intent is to run it only on Unix and GNU/Linux systems.
> > 
> > If non-Posix systems are relevant, you should be aware that <pwd.h>
> > and the getpwuid function are not universally available.
> 
> Can getpwuid etc be emulated on MSDOS and Mac as they are on Windows?

DJGPP already has getpwuid in its library, so the problem doesn't
exist in the MS-DOS port.

If Windows doesn't have this problem, then I guess we only need to
worry about Unix systems that don't have this function.  I don't know
whether this is a practical consideration, just that the previous
Posix standard didn't define it.

Re: update-game-score

[Colin Walters]

[ No need to CC me, by the way, since I read this list ]

On Sat, 2002-04-06 at 03:18, Eli Zaretskii wrote:
> IMHO, this code needs to take non-Posix platforms into consideration,
> unless the intent is to run it only on Unix and GNU/Linux systems.

Well, ok.  But I personally don't have (superuser) access to anything
besides Debian GNU/Linux, which makes testing it elsewhere difficult.

> If non-Posix systems are relevant, you should be aware that <pwd.h>
> and the getpwuid function are not universally available.  In fact,
> AFAIK, getpwuid wasn't even part of Posix until very recently, so some
> older Posix systems might not have it as well.  So some
> autoconfiscation or system-dependent ifdef's are in order.

Yeah. I imagine some system-dependent ifdefs will sneak in there.  But
at this point, it's still very much a work in progress...

Re: update-game-score

[Colin Walters]

On Sat, 2002-04-06 at 19:18, Colin Walters wrote:

> Yeah. I imagine some system-dependent ifdefs will sneak in there.  But
> at this point, it's still very much a work in progress...

Ok, I've committed the changes necessary to use it, and it seems to
work.  I'm not particularly satisfied with the implementation at this
point; the lib-src/Makefile has the names of the game score files
hardcoded, and "~/.emacs.d/games" is known to both gamegrid.el and
update-game-score.c.  

The former could probably be fixed by doing something like:

touch $(../src/emacs -batch -l ../lisp/play/tetris.el --eval '(princ
tetris-score-file)')

But doing that kind of makes me uncomfortable, because it's just sort of
hardcoding it a little bit less.  Any suggestions appreciated.

I think I know how to fix the latter correctly; will do so soon, but I
at least wanted to have something working in CVS.

Re: update-game-score

[Eli Zaretskii]

> From: Colin Walters <walters@verbum.org>
> Date: 11 Apr 2002 03:06:30 -0400
> 
> On Sat, 2002-04-06 at 19:18, Colin Walters wrote:
> 
> > Yeah. I imagine some system-dependent ifdefs will sneak in there.  But
> > at this point, it's still very much a work in progress...
> 
> Ok, I've committed the changes necessary to use it, and it seems to
> work.  I'm not particularly satisfied with the implementation at this
> point; the lib-src/Makefile has the names of the game score files
> hardcoded, and "~/.emacs.d/games" is known to both gamegrid.el and
> update-game-score.c.  

How about keeping the old code, both in gamegrid.el and in games that
use it, for non-Posix platforms that don't care about security
(Windows and MS-DOS)?  That would avoid the need to figure out where
to put the score files on systems where ${prefix}/var/games/emacs
cannot be taken for granted (and therefore creating files there at
"make install" time might not succeed).

Re: update-game-score

[Colin Walters]

On Fri, 2002-04-12 at 08:43, Eli Zaretskii wrote:

> How about keeping the old code, both in gamegrid.el and in games that
> use it, for non-Posix platforms that don't care about security
> (Windows and MS-DOS)?  

Admittedly I haven't really used Windows in several years, but I thought
recent versions were multiuser-capable?  

But, I really don't know how to make update-game-score work on Windows,
so if no one else wants to do it, then I think we can just make a
conditional on system-type inside `gamegrid-add-score'.

Re: update-game-score

[Eli Zaretskii]

> From: Colin Walters <walters@verbum.org>
> Date: 12 Apr 2002 15:05:15 -0400
> 
> On Fri, 2002-04-12 at 08:43, Eli Zaretskii wrote:
> 
> > How about keeping the old code, both in gamegrid.el and in games that
> > use it, for non-Posix platforms that don't care about security
> > (Windows and MS-DOS)?  
> 
> Admittedly I haven't really used Windows in several years, but I thought
> recent versions were multiuser-capable?  

They are; but the security support is (IIRC) nowhere as serious and
versatile as in Unix and GNU systems.

> But, I really don't know how to make update-game-score work on Windows,

I think it will work as-is on Windows, but the nuisance with finding a
place for the score file is something that needs to be resolved
regardless.

> I think we can just make a conditional on system-type inside
> `gamegrid-add-score'.

That's what I meant.  Please include ms-dos in that conditional; I'll
leave it up to Jason to say what should be done for the Windows port.

update-game-score

[Richard Stallman]

update-game-score uses the POSIX functions strerror and difftime
and seems to have no way to do without them.

Would someone like to make it work even if those functions are
missing?

Re: update-game-score

[Benjamin Riefenstahl]

Richard Stallman <rms@gnu.org> writes:
> update-game-score uses the POSIX functions strerror and difftime and
> seems to have no way to do without them.

Just a note: These two are in C89 also.  I am not sure if that makes a
difference for you.