unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Sam Steingold <sds@gnu.org>
Cc: emacs-devel@gnu.org
Subject: smtpmail.el
Date: 26 Apr 2002 10:55:56 -0400	[thread overview]
Message-ID: <m3n0vqcxvn.fsf@gnu.org> (raw)

Your recent patches to smtpmail.el broke it for me.
In `smtpmail-try-auth-methods', the `supported-extensions' does not
have 'auth, so `mechs' is nil, `mech' is nil, and I am asked for a
(useless!) password before getting 
        (error "Mechanism %s not implemented" nil)
For now, I just use the appended patch.
Is it okay to check it in?

-- 
Sam Steingold (http://www.podval.org/~sds) running RedHat7.2 GNU/Linux
<http://www.camera.org> <http://www.iris.org.il> <http://www.memri.org/>
<http://www.palestine-central.com/> <http://www.mideasttruth.com/>
There is Truth, and its value is T.  Or just non-NIL.  So 0 is True!


--- smtpmail.el.~1.40.~	Fri Apr 26 08:03:58 2002
+++ smtpmail.el	Fri Apr 26 10:55:09 2002
@@ -477,7 +477,7 @@
 			   (netrc-get hostentry "password")))
 		 (smtpmail-find-credentials
 		  smtpmail-auth-credentials host port)))
-	 (passwd (when cred
+	 (passwd (when (and mech cred)
 		   (or (smtpmail-cred-passwd cred)
 		       (read-passwd
 			(format "SMTP password for %s:%s: "
@@ -520,8 +520,8 @@
 		(not (integerp (car ret)))
 		(>= (car ret) 400))
 	    (throw 'done nil)))
-       (t
-	(error "Mechanism %s not implemented" mech)))
+       (t ;; no auth mech - do nothing
+        ))
       ;; Remember the password.
       (when (and (not (stringp smtpmail-auth-credentials))
 		 (null (smtpmail-cred-passwd cred)))

             reply	other threads:[~2002-04-26 14:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-04-26 14:55 Sam Steingold [this message]
2002-04-26 20:51 ` smtpmail.el Simon Josefsson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3n0vqcxvn.fsf@gnu.org \
    --to=sds@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).