From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Sam Steingold Newsgroups: gmane.emacs.devel Subject: smtpmail.el Date: 26 Apr 2002 10:55:56 -0400 Sender: emacs-devel-admin@gnu.org Message-ID: Reply-To: sds@gnu.org NNTP-Posting-Host: localhost.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: main.gmane.org 1019840162 27396 127.0.0.1 (26 Apr 2002 16:56:02 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Fri, 26 Apr 2002 16:56:02 +0000 (UTC) Cc: emacs-devel@gnu.org Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.33 #1 (Debian)) id 17190s-00077i-00 for ; Fri, 26 Apr 2002 18:56:02 +0200 Original-Received: from fencepost.gnu.org ([199.232.76.164]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 17193a-0005bp-00 for ; Fri, 26 Apr 2002 18:58:51 +0200 Original-Received: from localhost ([127.0.0.1] helo=fencepost.gnu.org) by fencepost.gnu.org with esmtp (Exim 3.34 #1 (Debian)) id 1717rc-00079w-00; Fri, 26 Apr 2002 11:42:24 -0400 Original-Received: from out002pub.verizon.net ([206.46.170.141] helo=out002.verizon.net) by fencepost.gnu.org with smtp (Exim 3.34 #1 (Debian)) id 17178j-00033X-00 for ; Fri, 26 Apr 2002 10:56:02 -0400 Original-Received: from gnu.org ([151.203.48.59]) by out002.verizon.net (InterMail vM.5.01.04.05 201-253-122-122-105-20011231) with ESMTP id <20020426145605.XTHU4379.out002.verizon.net@gnu.org>; Fri, 26 Apr 2002 09:56:05 -0500 Original-To: Simon Josefsson X-Attribution: Sam X-Disclaimer: You should not expect anyone to agree with me. Mail-Copies-To: never Original-Lines: 37 User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.2.50 Errors-To: emacs-devel-admin@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.0.9 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: Xref: main.gmane.org gmane.emacs.devel:3310 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:3310 Your recent patches to smtpmail.el broke it for me. In `smtpmail-try-auth-methods', the `supported-extensions' does not have 'auth, so `mechs' is nil, `mech' is nil, and I am asked for a (useless!) password before getting (error "Mechanism %s not implemented" nil) For now, I just use the appended patch. Is it okay to check it in? -- Sam Steingold (http://www.podval.org/~sds) running RedHat7.2 GNU/Linux There is Truth, and its value is T. Or just non-NIL. So 0 is True! --- smtpmail.el.~1.40.~ Fri Apr 26 08:03:58 2002 +++ smtpmail.el Fri Apr 26 10:55:09 2002 @@ -477,7 +477,7 @@ (netrc-get hostentry "password"))) (smtpmail-find-credentials smtpmail-auth-credentials host port))) - (passwd (when cred + (passwd (when (and mech cred) (or (smtpmail-cred-passwd cred) (read-passwd (format "SMTP password for %s:%s: " @@ -520,8 +520,8 @@ (not (integerp (car ret))) (>= (car ret) 400)) (throw 'done nil))) - (t - (error "Mechanism %s not implemented" mech))) + (t ;; no auth mech - do nothing + )) ;; Remember the password. (when (and (not (stringp smtpmail-auth-credentials)) (null (smtpmail-cred-passwd cred)))